Review main Merged

64305[BUGFIX] Show content for columns with colPos set only

Simon Gilli CR +2 V +2 Hard +458 −5 updated 06/08/20, 20:07

Commit message

Setting up backend layouts with colPos not set will show the content of
column 0 because of an excplicit cast of the colPos. This patch checks
if colPos is set and if not skips the assignment of records.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1824

  1. Simon Gilli uploaded patch set 1 04/22/20, 18:18

  2. TYPO3com voted on patch set 1 V +1 04/22/20, 18:31 Completed build in 12m 19s on Wed, 22 Apr, 06:31 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2988

  3. Simon Gilli wrote 04/22/20, 18:31

    Topic set to backend
  4. Josef Glatz commented on patch set 1 V +1 CR +1 04/23/20, 07:57

    super! for the records: yes it is valid to leave colPos option empty when configuring a backendLayout column
  5. Simon Gilli marked it work in progress 04/24/20, 13:42

  6. Simon Gilli rebased onto patch set 2 05/14/20, 15:18

  7. TYPO3com voted on patch set 2 V +1 05/14/20, 15:30 Completed build in 12m 19s on Thu, 14 May, 03:30 PM Test Summary: 73726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3379

  8. Simon Gilli uploaded patch set 3 05/16/20, 08:15

  9. Simon Gilli commented on patch set 3 05/16/20, 08:17

    Please have a look at my tests. Not only added ones for this issue but also other common cases. The yaml file contains to much data currently, not sure if we should cleanup it or if it's ok like this.
  10. Simon Gilli commented on patch set 3 05/16/20, 08:18

    > Patch Set 3: > > Please have a look at my tests. Not only added ones for this issue but also other common cases. The yaml file contains to much data currently, not sure if we should cleanup it or if it's ok like this. Btw the last test should fail if you omit my change.
  11. Simon Gilli uploaded patch set 4 05/16/20, 08:21

  12. TYPO3com voted on patch set 3 V -1 05/16/20, 08:31 Completed build in 16m 04s on Sat, 16 May, 08:31 AM Test Summary: 72636 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3395

  13. TYPO3com voted on patch set 4 V -1 05/16/20, 08:37 Completed build in 15m 54s on Sat, 16 May, 08:37 AM Test Summary: 1 of 74235 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3396

  14. TYPO3com voted on patch set 4 V +1 05/16/20, 09:37 Completed build in 11m 21s on Sat, 16 May, 09:37 AM Test Summary: 73751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3397

  15. Benni Mack updated the commit message in patch set 5 05/25/20, 18:52

  16. Benni Mack commented on patch set 5 06/03/20, 08:49

    BackendLayoutRendererScenario.yaml:118

    looks like we don't need the multi-site setup definition + pages, right?
  17. Benni Mack commented on patch set 5 06/03/20, 08:51

    Thanks a ton for providing the tests, this shows exactly the problem and explains your fix. In addition, we could use the fixture for more tests than just BackendLayoutRenderer, so you could rename the Fixture and put it into typo3/sysext/backend/Tests/Functional/View/Fixtures directly.
  18. Oliver Klee commented on patch set 5 06/03/20, 10:32

    BackendLayoutRendererTest.php:3

    Strict, please (so all new classes are strict by default).
  19. Simon Gilli uploaded patch set 6 06/05/20, 14:08

  20. Simon Gilli commented on patch set 6 06/05/20, 14:09

    BackendLayoutRendererTest.php:3 Reply

    Done

    BackendLayoutRendererScenario.yaml:118 Reply

    Done
  21. TYPO3com voted on patch set 6 V +1 06/05/20, 14:40 Completed build in 30m 24s on Fri, 5 Jun, 02:40 PM Test Summary: 72824 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3866

  22. Benni Mack voted on patch set 6 V +1 CR +1 06/08/20, 15:03

  23. Andreas Kienast voted on patch set 6 V +2 CR +2 06/08/20, 20:07

  24. Andreas Kienast merged patch set 7 06/08/20, 20:07