Review main Merged

64309[BUGFIX] Re-determine first start module if configuration is invalid

Andreas Kienast CR +2 V +2 Easy +12 −7 updated 05/12/20, 15:01

Commit message

This patch fixes two flaws with the determination and loading of the
first available backend module:

* ModuleLoader::getModuleSetupInformation() only sets default options if
  the configuration array is not empty
* The availability of the module is checked. If the configured module
  doesn't exist, the first available module is determined again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Siepmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Andreas Kienast uploaded patch set 1 04/23/20, 12:45

  2. Daniel Siepmann voted on patch set 1 V +1 04/23/20, 12:49

  3. Andreas Kienast commented on patch set 1 04/23/20, 12:51

    @Benni do you think the change in ModuleLoader is feasible?
  4. TYPO3com voted on patch set 1 V +1 04/23/20, 12:58 Completed build in 13m 01s on Thu, 23 Apr, 12:58 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2996

  5. Andreas Kienast updated the commit message in patch set 2 04/27/20, 19:07

  6. TYPO3com voted on patch set 2 V +1 04/27/20, 19:20 Completed build in 12m 44s on Mon, 27 Apr, 07:20 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3062

  7. Daniel Siepmann commented on patch set 2 V +1 CR +1 04/28/20, 19:31

    Didn't test with workspaces.
  8. Josef Glatz commented on patch set 2 CR +1 04/30/20, 05:33

    What exactly needs to be tested in the workspaces sector for this patch?
  9. Benni Mack voted on patch set 2 V +2 CR +2 04/30/20, 06:57

  10. Benni Mack merged patch set 3 04/30/20, 06:57

  11. Helmut Hummel commented on patch set 3 05/12/20, 15:01

    ModuleLoader.php:229 Unresolved

    This change (although valid) causes a regression: https://forge.typo3.org/issues/91368