64309[BUGFIX] Re-determine first start module if configuration is invalid
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Daniel Siepmann +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Siepmann +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 911
-
Andreas Kienast uploaded patch set 1 04/23/20, 12:45
-
Daniel Siepmann voted on patch set 1 V +1 04/23/20, 12:49
-
Andreas Kienast commented on patch set 1 04/23/20, 12:51
@Benni do you think the change in ModuleLoader is feasible? -
TYPO3com voted on patch set 1 V +1 04/23/20, 12:58 Completed build in 13m 01s on Thu, 23 Apr, 12:58 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2996
-
Andreas Kienast updated the commit message in patch set 2 04/27/20, 19:07
-
TYPO3com voted on patch set 2 V +1 04/27/20, 19:20 Completed build in 12m 44s on Mon, 27 Apr, 07:20 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3062
-
Daniel Siepmann commented on patch set 2 V +1 CR +1 04/28/20, 19:31
Didn't test with workspaces. -
Josef Glatz commented on patch set 2 CR +1 04/30/20, 05:33
What exactly needs to be tested in the workspaces sector for this patch? -
Benni Mack voted on patch set 2 V +2 CR +2 04/30/20, 06:57
-
Benni Mack merged patch set 3 04/30/20, 06:57
-
Helmut Hummel commented on patch set 3 05/12/20, 15:01
ModuleLoader.php:229UnresolvedThis change (although valid) causes a regression: https://forge.typo3.org/issues/91368