64310[BUGFIX] Re-introduce sorting for updateable and (un)installed extensions
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 78
-
Andreas Kienast uploaded patch set 1 04/23/20, 15:59
-
Andreas Kienast commented on patch set 1 04/23/20, 16:02
-
TYPO3com voted on patch set 1 V +1 04/23/20, 16:11 Completed build in 11m 57s on Thu, 23 Apr, 04:11 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3003
-
Josef Glatz commented on patch set 1 V +1 CR +1 04/24/20, 05:50
Works like a charm! Tested in all my browsers under macOS What about the "State" column? It isn't sortable with the patch. Sorting for State column makes as much sense as sorting the versions. I am emotionless there. Didn't even know that such sorting was there before 😎 -
Andreas Kienast commented on patch set 1 04/24/20, 05:54
> Patch Set 1: Verified+1 Code-Review+1 > > Works like a charm! Tested in all my browsers under macOS > > What about the "State" column? Sorting by state wasn't possible in 10.3 as well, so I wouldn't touch that. Sorting by state and version both don't make much sense to me, but hey... -
Josef Glatz commented on patch set 1 04/24/20, 05:58
> Patch Set 1: > > > Patch Set 1: Verified+1 Code-Review+1 > > > > Works like a charm! Tested in all my browsers under macOS > > > > What about the "State" column? > > Sorting by state wasn't possible in 10.3 as well, so I wouldn't touch that. Sorting by state and version both don't make much sense to me, but hey... I mean, yeah, it's fully ok, therefore I like your patch 🥰 -
Benni Mack voted on patch set 1 V +2 CR +2 04/27/20, 07:48
-
Benni Mack merged patch set 2 04/27/20, 07:48
tablesort.d.ts:6Unresolved