Review main Merged

64311[TASK] Enhance custom event dispatching in modal dialog

Oliver Hader CR +2 V +2 Easy +22 −6 updated 05/04/20, 07:08

Commit message

* allows custom events to bubble up in DOM tree
* ensures that custom events are dispatched at those elements
  that initially contained the `data-event-name` attributes

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Oliver Hader uploaded patch set 1 04/24/20, 11:42

  2. TYPO3com voted on patch set 1 V +1 04/24/20, 12:00 Completed build in 18m 06s on Fri, 24 Apr, 12:00 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3017

  3. Benni Mack voted on patch set 1 CR +1 04/28/20, 08:35

  4. Oliver Hader commented on patch set 1 05/02/20, 12:28

    @Susi: Maybe you'd like to vote here as well, since you successfully tested event bubbling in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225 already :)
  5. Susi Moog voted on patch set 1 V +1 CR +1 05/04/20, 04:30

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 05/04/20, 07:08

  7. Andreas Kienast merged patch set 2 05/04/20, 07:08