Review main Merged

64312[BUGFIX] Allow more characters for MySQL / MariaDB database name

Manuel Selbach CR +2 V +2 Easy +39 −6 updated 05/12/20, 07:10

Commit message

With this change it is possible to use a wider set of characters.
Please have a look at the official documentation of MySQL / MariaDB.

e.g.:

https://dev.mysql.com/doc/refman/5.5/en/identifiers.html
https://dev.mysql.com/doc/refman/5.6/en/identifiers.html
https://dev.mysql.com/doc/refman/5.7/en/identifiers.html
https://dev.mysql.com/doc/refman/8.0/en/identifiers.html
https://mariadb.com/kb/en/identifier-names/

The mentioned characters in chapter "Quoted" (ASCII and Extended) are
supported by now.

Furthermore the database name is quoted during the installation process
for creating / dropping a database.

If, for example a `.` is used in the name, a notification will be shown.

e.g.:

```
Unable to create database
Database with name "foo.test@bla123" could not be created. Either your database name contains a reserved keyword or your database user does not have sufficient permissions to create it or the database already exists. Please choose an existing (empty) database, choose another name or contact administration.
```

Review

  • Code review CR +2 Done
    • Manuel Selbach +2
    • Andreas Kienast +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Manuel Selbach +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Manuel Selbach uploaded patch set 1 04/24/20, 12:21

  2. TYPO3com voted on patch set 1 V -1 04/24/20, 12:22 Completed build in 23s on Fri, 24 Apr, 12:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3018

  3. Manuel Selbach uploaded patch set 2 04/24/20, 14:17

  4. TYPO3com voted on patch set 2 V +1 04/24/20, 14:29 Completed build in 11m 46s on Fri, 24 Apr, 02:29 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3019

  5. Benni Mack voted on patch set 2 V +1 CR +1 04/28/20, 08:36

  6. Andreas Kienast voted on patch set 2 CR +1 04/28/20, 08:59

  7. Oliver Hader voted on patch set 2 CR +1 05/11/20, 14:15

  8. Manuel Selbach voted on patch set 2 V +2 CR +2 05/12/20, 07:10

  9. Manuel Selbach merged patch set 3 05/12/20, 07:10