Review main Merged

64316[TASK] Replace usage of GeneralUtility::milliseconds in Indexer

Georg Ringer CR +2 V +2 Easy +2 −2 updated 04/27/20, 09:11

Commit message

Replace the usage of `GeneralUtility::milliseconds` in Indexer class
which has been deprecated with 91001.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Georg Ringer uploaded patch set 1 04/26/20, 07:18

  2. Georg Ringer commented on patch set 1 04/26/20, 07:18

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 04/26/20, 07:29 Completed build in 11m 13s on Sun, 26 Apr, 07:29 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3028

  4. Josef Glatz voted on patch set 1 V +1 CR +1 04/26/20, 08:24

  5. Oliver Klee voted on patch set 1 CR +1 04/26/20, 09:32

  6. Benni Mack commented on patch set 1 04/26/20, 18:28

    we've moved this method into IndexedSearchutility::milliseconds.
  7. Benni Mack voted on patch set 1 CR -1 04/26/20, 18:28

  8. Josef Glatz uploaded patch set 2 04/27/20, 04:29

  9. Josef Glatz voted on patch set 2 V +1 CR +1 04/27/20, 04:30

  10. TYPO3com voted on patch set 2 V -1 04/27/20, 05:16 Completed build in 47m 03s on Mon, 27 Apr, 05:16 AM Test Summary: 88 of 73813 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3038

  11. Benni Mack commented on patch set 2 CR +1 04/27/20, 06:08

    Thank you all for fixing this issue. That bug was on me!
  12. TYPO3com voted on patch set 2 V +1 04/27/20, 08:14 Completed build in 12m 04s on Mon, 27 Apr, 08:14 AM Test Summary: 73655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3043

  13. Benni Mack voted on patch set 2 V +2 CR +2 04/27/20, 09:11

  14. Benni Mack merged patch set 3 04/27/20, 09:11