Review main Abandoned

64318[BUGFIX] Overlay current page language for TMENU.showAccessRestrictedPages

Jonas Eberle CR 0 V 0 Normal +228 −1 updated 05/02/20, 19:58

Commit message

AbstractMenuContentObject::makeMenu() tries to lift group restrictions
for the PageRespository if showAccessRestrictedPages is set, but this
was probably overseen when migrating to QueryBuilder.

This also adds a test for TMENU.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 59

  1. Jonas Eberle uploaded patch set 1 04/26/20, 21:43

  2. TYPO3com voted on patch set 1 V -1 04/26/20, 21:55 Completed build in 11m 45s on Sun, 26 Apr, 09:55 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3035

  3. Jonas Eberle uploaded patch set 2 04/27/20, 00:21

  4. TYPO3com voted on patch set 2 V -1 04/27/20, 00:36 Completed build in 14m 07s on Mon, 27 Apr, 12:36 AM Test Summary: 1 of 74144 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3037

  5. TYPO3com voted on patch set 1 V +1 04/27/20, 04:25 Completed build in 6h 53m 10s on Mon, 27 Apr, 04:25 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3035

  6. Jonas Eberle uploaded patch set 3 04/27/20, 07:31

  7. Jonas Eberle wrote 04/27/20, 07:33

    Description set to "adds pages.sorting in order to fix postgres tests"
  8. TYPO3com voted on patch set 3 V +1 04/27/20, 07:43 Completed build in 11m 09s on Mon, 27 Apr, 07:42 AM Test Summary: 73660 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3042

  9. Jonas Eberle abandoned the change 05/02/20, 19:58