Review main Merged

64320[BUGFIX] Do not disable caching for caches with TransientMemoryBackend

Stephan Großberndt CR +2 V +2 Easy +2 −1 updated 04/27/20, 15:41

Commit message

If caching is disabled in the CacheManager, caches using the
TransientMemoryBackend are not adjusted to NullBackend anymore.

This mainly affects the runtime cache, which is memory-based anyways
and should be a "forget after the request"-cache.

This also fixes a PDOException in the page slug update wizard when
using PostgreSQL, as the Install Tool is using the core in "no-cache"
mode. (See entry point of the Install Tool)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stephan Großberndt +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stephan Großberndt +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1519

  1. Stephan Großberndt uploaded patch set 1 04/27/20, 11:39

  2. Stephan Großberndt uploaded patch set 2 04/27/20, 11:48

  3. Markus Klein commented on patch set 2 04/27/20, 11:49

    Lets change this to describe that we actually change. Namely the behavior of the runtime cache by not running serialization if NullBAckend
  4. TYPO3com voted on patch set 1 V -1 04/27/20, 11:52 Completed build in 12m 36s on Mon, 27 Apr, 11:52 AM Test Summary: 1 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3044

  5. Benjamin Franzke commented on patch set 1 04/27/20, 11:56

    VariableFrontend.php:59

    It is of course ugly for the VariableFrontend to know about the NullBackend. We could also patch the CacheManager to not disable cache-disabling for the runtime cache. Both solutions kinda suck, the one you proposed seems like being less ugly than patching CacheManager.

    VariableFrontend.php:85 Unresolved

    I know, it feels logically to also add the condition to get() when adding one to set(), but `NullBackend` will never return a result. Therefore this condition will (and MUST) never be reached. $backend->get() will always returns false, which means the previous condition will ($rawResult === false) will suffice.
  6. Stephan Großberndt commented on patch set 2 04/27/20, 11:57

    Reply Unresolved

    "[BUGFIX] Do not serialize for NullBackend cache"?
  7. TYPO3com voted on patch set 2 V +1 04/27/20, 12:06 Completed build in 15m 53s on Mon, 27 Apr, 12:06 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3046

  8. Benjamin Franzke uploaded patch set 3 04/27/20, 12:11

  9. Benjamin Franzke commented on patch set 3 04/27/20, 12:12

    VariableFrontend.php:59 Reply Unresolved

    I gave this another thought and I think patching this in CacheManager is more straight forward. Uploaded as patchset 3. Please take a look and test.
  10. Benjamin Franzke voted on patch set 3 CR +1 04/27/20, 12:13

  11. TYPO3com voted on patch set 3 V +1 04/27/20, 12:22 Completed build in 11m 53s on Mon, 27 Apr, 12:22 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3047

  12. Markus Klein updated the commit message in patch set 4 04/27/20, 12:43

  13. Markus Klein commented on patch set 4 CR +1 04/27/20, 12:43

    I rephrased the commit message now
  14. TYPO3com voted on patch set 4 V +1 04/27/20, 12:54 Completed build in 11m 30s on Mon, 27 Apr, 12:54 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3050

  15. Benjamin Franzke voted on patch set 4 CR +1 04/27/20, 13:18

  16. Stephan Großberndt commented on patch set 4 V +1 CR +1 04/27/20, 13:49

    Thanks!
  17. Markus Klein voted on patch set 4 V +1 04/27/20, 13:56

  18. Benjamin Franzke commented on patch set 4 V +2 CR +2 04/27/20, 15:41

    Thanks, I've now also actually tested this with Postgresql. It is good to go.
  19. Benjamin Franzke merged patch set 5 04/27/20, 15:41