64329[TASK] Allow overriding current site url during installation
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1521
-
Helmut Hummel uploaded patch set 1 04/27/20, 21:33
-
TYPO3com voted on patch set 1 V -1 04/27/20, 21:50 Completed build in 16m 53s on Mon, 27 Apr, 09:50 PM Test Summary: 1 of 73820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3070
-
Benjamin Franzke commented on patch set 1 04/27/20, 21:55
-
Benni Mack commented on patch set 1 04/28/20, 05:14
InstallerController.php:1363ReplyAdding a comment is fine for now when it is used. -
Benni Mack commented on patch set 2 04/28/20, 05:16
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V -1 04/28/20, 05:30 Completed build in 13m 42s on Tue, 28 Apr, 05:30 AM Test Summary: 11 of 73174 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3077
-
Benjamin Franzke voted on patch set 2 V +1 CR +1 04/28/20, 06:33
-
TYPO3com voted on patch set 2 V +1 04/28/20, 07:15 Completed build in 13m 29s on Tue, 28 Apr, 07:15 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3079
-
Helmut Hummel uploaded patch set 3 04/28/20, 07:24
-
Helmut Hummel commented on patch set 3 04/28/20, 07:26
InstallerController.php:1363ReplyDone -
Benni Mack commented on patch set 3 04/28/20, 07:43
InstallerController.php:1363ReplyYou added a comment in PS3? I added one in PS2 and you removed it again. Don't get it.. :) -
Benjamin Franzke uploaded patch set 4 04/28/20, 07:48
-
Benjamin Franzke commented on patch set 4 V +1 CR +1 04/28/20, 07:49
InstallerController.php:1363ReplyI've re-added the comment. -
Helmut Hummel uploaded patch set 5 04/28/20, 07:52
-
TYPO3com voted on patch set 3 V +1 04/28/20, 07:53 Completed build in 29m 35s on Tue, 28 Apr, 07:53 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3082
-
Helmut Hummel commented on patch set 5 04/28/20, 07:55
InstallerController.php:1363Replysorry accidentally pushed an empty commit. patch set is not current with a langer comment and POST values instead of query argument to be in line with other arguments passed to the controller -
Benjamin Franzke voted on patch set 5 V +1 CR +1 04/28/20, 08:00
-
TYPO3com voted on patch set 4 V +1 04/28/20, 08:24 Completed build in 15m 18s on Tue, 28 Apr, 08:23 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3085
-
TYPO3com voted on patch set 5 V +1 04/28/20, 08:28 Completed build in 19m 59s on Tue, 28 Apr, 08:28 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3086
-
Benni Mack voted on patch set 5 V +2 CR +2 04/28/20, 08:34
-
Benni Mack merged patch set 6 04/28/20, 08:34
InstallerController.php:1363