Review main Merged

64329[TASK] Allow overriding current site url during installation

Helmut Hummel CR +2 V +2 Easy +7 −1 updated 04/28/20, 08:34

Commit message

Especially to ease using the API on CLI,
we now add a request argument for the siteUrl
which is preferred over the current site url to
create a default site configuration.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1521

  1. Helmut Hummel uploaded patch set 1 04/27/20, 21:33

  2. TYPO3com voted on patch set 1 V -1 04/27/20, 21:50 Completed build in 16m 53s on Mon, 27 Apr, 09:50 PM Test Summary: 1 of 73820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3070

  3. Benjamin Franzke commented on patch set 1 04/27/20, 21:55

    InstallerController.php:1363

    Sorry, but I think this makes the code really hard to read. We'll never be able to figure out when `siteUrl` has actually being set in 1-2 years because no one knows that typo3-console is setting this parameter.. It looks like the query parameter is the preferred way to set a siteUrl, while core does only – and always – use the one that now would look like a fallback. It's a pity, but I have no idea how we could add an API for typo3-console in a non ugly way (without refactoring the code from InstallerController into a Service) :\
  4. Benni Mack commented on patch set 1 04/28/20, 05:14

    InstallerController.php:1363 Reply

    Adding a comment is fine for now when it is used.
  5. Benni Mack commented on patch set 2 04/28/20, 05:16

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V -1 04/28/20, 05:30 Completed build in 13m 42s on Tue, 28 Apr, 05:30 AM Test Summary: 11 of 73174 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3077

  7. Benjamin Franzke voted on patch set 2 V +1 CR +1 04/28/20, 06:33

  8. TYPO3com voted on patch set 2 V +1 04/28/20, 07:15 Completed build in 13m 29s on Tue, 28 Apr, 07:15 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3079

  9. Helmut Hummel uploaded patch set 3 04/28/20, 07:24

  10. Helmut Hummel commented on patch set 3 04/28/20, 07:26

    InstallerController.php:1363 Reply

    Done
  11. Benni Mack commented on patch set 3 04/28/20, 07:43

    InstallerController.php:1363 Reply

    You added a comment in PS3? I added one in PS2 and you removed it again. Don't get it.. :)
  12. Benjamin Franzke uploaded patch set 4 04/28/20, 07:48

  13. Benjamin Franzke commented on patch set 4 V +1 CR +1 04/28/20, 07:49

    InstallerController.php:1363 Reply

    I've re-added the comment.
  14. Helmut Hummel uploaded patch set 5 04/28/20, 07:52

  15. TYPO3com voted on patch set 3 V +1 04/28/20, 07:53 Completed build in 29m 35s on Tue, 28 Apr, 07:53 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3082

  16. Helmut Hummel commented on patch set 5 04/28/20, 07:55

    InstallerController.php:1363 Reply

    sorry accidentally pushed an empty commit. patch set is not current with a langer comment and POST values instead of query argument to be in line with other arguments passed to the controller
  17. Benjamin Franzke voted on patch set 5 V +1 CR +1 04/28/20, 08:00

  18. TYPO3com voted on patch set 4 V +1 04/28/20, 08:24 Completed build in 15m 18s on Tue, 28 Apr, 08:23 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3085

  19. TYPO3com voted on patch set 5 V +1 04/28/20, 08:28 Completed build in 19m 59s on Tue, 28 Apr, 08:28 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3086

  20. Benni Mack voted on patch set 5 V +2 CR +2 04/28/20, 08:34

  21. Benni Mack merged patch set 6 04/28/20, 08:34