Review main Merged

64331[TASK] Replace <style> for compliance with CSP header in svgs

TYPO3com CR +2 V +2 Easy +8 −8 updated 02/09/21, 13:16

Commit message

SVG with inline styles are not loaded when the Content-Security-Policy
header contains the widely used setting "style-src 'self';" because
the browser has to reject interpreting the style attribute.
In this case a black rectangle is displayed.
Using attributes instead of styles is compliant with CSP "style-src
'self';" and the svgs can be displayed.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 1219

  1. TYPO3com uploaded patch set 1 04/27/20, 23:07

  2. TYPO3com voted on patch set 1 V -1 04/27/20, 23:39 Completed build in 31m 50s on Mon, 27 Apr, 11:39 PM Test Summary: 13 of 72853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3076

  3. TYPO3com voted on patch set 1 V +1 04/28/20, 09:14 Completed build in 10h 38m 16s on Tue, 28 Apr, 09:14 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3076

  4. Oliver Klee commented on patch set 1 04/28/20, 16:20

    You might want to configure your name and email address in your git client.

    Unresolved

    must rejects to load -> must reject loading
  5. Andreas Kienast commented on patch set 1 04/28/20, 21:11

    Reply Unresolved

    This patch was originally pushed to Github, Intercept just pushed it to Gerrit.
  6. Benni Mack updated the commit message in patch set 2 05/25/20, 18:48

  7. Oliver Hader voted on patch set 2 CR +1 01/04/21, 14:29

  8. Benjamin Franzke commented on patch set 2 CR -1 01/04/21, 15:09

    Also applies to: typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.svg typo3/sysext/install/Resources/Public/Images/TestInput/Test.svg typo3/sysext/redirects/Resources/Public/Icons/mimetypes-x-sys_redirect.svg And also to the following T3Icons which need to be updated in https://github.com/TYPO3/TYPO3.Icons # (well, this one is special, as it uses <svg class="typo3-icons" style="display: none;") typo3/sysext/core/Resources/Public/Icons/T3Icons/actions.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-open-document-formula.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-pdf.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-powerpoint.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-text-css.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-text-html.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-text-js.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-text-php.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-word.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-x-sys_language.svg typo3/sysext/core/Resources/Public/Icons/T3Icons/mimetypes/mimetypes-x-tx_rtehtmlarea_acronym.svg PS: Command used: git grep -l "style=" -- '*.svg'
  9. Benjamin Franzke uploaded patch set 3 02/09/21, 00:03

  10. Benjamin Franzke commented on patch set 3 02/09/21, 00:03

    Reply

    Done for the "real" cases.
  11. Benjamin Franzke updated the commit message in patch set 4 02/09/21, 00:07

  12. TYPO3com voted on patch set 3 V -1 02/09/21, 00:13 Completed build in 09m 42s on Tue, 9 Feb, 12:13 AM Test Summary: 31852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9366

  13. core-ci voted on patch set 3 V +1 02/09/21, 00:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/503

  14. TYPO3com voted on patch set 4 V +1 02/09/21, 00:17 Completed build in 10m 18s on Tue, 9 Feb, 12:17 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9367

  15. core-ci voted on patch set 4 V +1 02/09/21, 00:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/504

  16. Oliver Hader voted on patch set 4 CR +1 02/09/21, 13:09

  17. Oliver Hader voted on patch set 4 V +2 CR +2 02/09/21, 13:11

  18. Oliver Hader merged patch set 5 02/09/21, 13:13

  19. Benni Mack commented on patch set 5 02/09/21, 13:16

    AFAIK these icons come from t3icons, so I wonder if we should fix it in the icons repository.