Review main Abandoned

64333[BUGFIX] Fetch original row from database when previewing a workspace

Markus Hackel CR 0 V 0 Normal +48 −4 updated 04/28/20, 07:11

Commit message

In the context of Extbase persistence layer fetching translated relations
within a workspace, the data to be overlaid may contain additional columns
from the MM relation table.

In order to prevent those columns to be queried, the vanilla record
should be fetched prior to try to overlay it.

If needed, additional columns from the JOIN are restored after the overlay
has been prepared.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Markus Hackel uploaded patch set 1 04/28/20, 06:40

  2. TYPO3com voted on patch set 1 V -1 04/28/20, 06:41 Completed build in 51s on Tue, 28 Apr, 06:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3078

  3. Sebastian Michaelsen commented on patch set 1 CR -1 04/28/20, 06:44

    Typo3DbBackend.php:30 Unresolved

    ArrayUtility seems not to be used
  4. Markus Hackel abandoned the change 04/28/20, 07:11

    accidentally created new patchset