Review main Abandoned

64334[BUGFIX] Ensure correct ordering of config keys

Andreas Kienast CR 0 V 0 Easy +4 −1 updated 04/28/20, 08:22

Commit message

In case an IRRE configuration contains a mix of associative items and
numeric-indexed items, the validation of the hmac may fail due to the
order of items before and after the de/encoding.

To fix this rather rare use-case, the configuration is now decoded and
afterwards encoded again to make absolutely sure the order of all items
is still the same.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. Andreas Kienast uploaded patch set 1 04/28/20, 07:19

  2. Andreas Kienast uploaded patch set 2 04/28/20, 07:20

  3. TYPO3com voted on patch set 1 V +1 04/28/20, 07:32 Completed build in 12m 35s on Tue, 28 Apr, 07:32 AM Test Summary: 73655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3080

  4. TYPO3com voted on patch set 2 V +1 04/28/20, 07:49 Completed build in 25m 38s on Tue, 28 Apr, 07:49 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3081

  5. Andreas Kienast commented on patch set 2 CR -2 04/28/20, 08:14

    Something is fishy in this part
  6. Andreas Kienast abandoned the change 04/28/20, 08:22