Review 9.5 Merged

64340[BUGFIX] Correctly use trigger_error for deprecations

Markus Klein CR +2 V +2 Easy +3 −3 updated 04/28/20, 19:33

Commit message

With ticket #90250 a few trigger_error() calls have
been introduced, which lack the second parameter
E_USER_DEPRECATED.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 67

  1. Markus Klein uploaded patch set 1 04/28/20, 18:34

  2. TYPO3com voted on patch set 1 V +1 04/28/20, 18:47 Completed build in 12m 19s on Tue, 28 Apr, 06:47 PM Test Summary: 74834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-547

  3. Wouter Wolters voted on patch set 1 CR +1 04/28/20, 18:49

  4. Josef Glatz commented on patch set 1 CR +1 04/28/20, 19:02

    🙈👍🏻
  5. Josef Glatz voted on patch set 1 V +1 04/28/20, 19:23

  6. Benni Mack voted on patch set 1 V +2 CR +2 04/28/20, 19:33

  7. Benni Mack merged patch set 2 04/28/20, 19:33