Review main Merged

64343[BUGFIX] Explicitly fetch element by ID instead of invoking querySelector

Andreas Kienast CR +2 V +2 Easy +17 −17 updated 05/01/20, 11:38

Commit message

The InlineControlContainer tried to fetch elements via `querySelector()`
previously. This fails once the selector contains a character that has a
specific meaning for the whole selector, e.g. a dot. Having a selector
`#foo-bar-settings.test` instructs the query selector to fetch an
element matching the ID `foo-bar-settings` and the class `test`.

As we handle IDs only, we can safely use `getElementById()` which
doesn't have the previously mentioned implications.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Raphael Zschorsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Raphael Zschorsch +1
    • Armin Vieweg +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 611

  1. Andreas Kienast uploaded patch set 1 04/29/20, 09:02

  2. TYPO3com voted on patch set 1 V -1 04/29/20, 09:03 Completed build in 48s on Wed, 29 Apr, 09:03 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3100

  3. TYPO3com commented on patch set 1 04/29/20, 09:06 Completed build in 48s on Wed, 29 Apr, 09:06 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3102

  4. TYPO3com commented on patch set 1 04/29/20, 09:31 Completed build in 53s on Wed, 29 Apr, 09:31 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3103

  5. TYPO3com commented on patch set 1 04/29/20, 10:27 Completed build in 16m 28s on Wed, 29 Apr, 10:27 AM Test Summary: 72506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3103

  6. TYPO3com voted on patch set 1 V +1 04/29/20, 11:57 Completed build in 28m 41s on Wed, 29 Apr, 11:57 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3103

  7. Raphael Zschorsch voted on patch set 1 V +1 CR +1 04/29/20, 15:16

  8. Armin Vieweg commented on patch set 1 V +1 04/29/20, 15:26

    I can confirm, that this fix works.
  9. Oliver Klee voted on patch set 1 CR +1 04/29/20, 15:39

  10. Andreas Kienast voted on patch set 1 V +2 CR +2 05/01/20, 11:38

  11. Andreas Kienast merged patch set 2 05/01/20, 11:38