64346[BUGFIX] Reintroduce filtering out non accessible pages on query time
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Benni Mack +2
-
Verified V +2 Done
- Richard Haeser +2
- Uwe Trotzek +1
- TYPO3com +1 CI
Issues 3
Files 2
Review log 2331
Show 46 earlier messages
-
Tymoteusz Motylewski uploaded patch set 1 04/29/20, 14:47
-
TYPO3com voted on patch set 1 V -1 04/29/20, 14:47 Completed build in 24s on Wed, 29 Apr, 02:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3108
-
Benni Mack commented on patch set 1 05/05/20, 05:49
-
Tymoteusz Motylewski uploaded patch set 2 05/08/20, 06:52
-
Tymoteusz Motylewski wrote 05/08/20, 06:53
Description set to "added tests" -
TYPO3com voted on patch set 2 V +1 05/08/20, 07:05 Completed build in 12m 55s on Fri, 8 May, 07:05 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3256
-
Tymoteusz Motylewski updated the commit message in patch set 3 05/08/20, 11:57
-
TYPO3com voted on patch set 3 V +1 05/08/20, 12:08 Completed build in 11m 18s on Fri, 8 May, 12:08 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3260
-
Benni Mack commented on patch set 3 05/11/20, 13:21
PageTreeRepository.php:195Unresolvedshould we use BackendUtility::BEgetRootline() instead? Or is there a reason for using RootlineUtility? -
Tymoteusz Motylewski commented on patch set 3 05/11/20, 20:14
no reason, can use BE utility -
Tymoteusz Motylewski commented on patch set 3 05/11/20, 20:23
> Patch Set 3: > > no reason, can use BE utility I think the reason was that rootline utility was used in Page/TreeController already. I will push a version with BEutility -
Tymoteusz Motylewski uploaded patch set 4 05/11/20, 20:41
-
TYPO3com voted on patch set 4 V +1 05/11/20, 21:03 Completed build in 21m 36s on Mon, 11 May, 09:03 PM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3317
-
Georg Ringer voted on patch set 4 V +1 CR +1 05/12/20, 06:14
-
Tymoteusz Motylewski uploaded patch set 5 05/20/20, 18:22
-
TYPO3com voted on patch set 5 V +1 05/20/20, 18:33 Completed build in 10m 42s on Wed, 20 May, 06:33 PM Test Summary: 73799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3471
-
Richard Haeser voted on patch set 5 V +1 CR +1 05/25/20, 09:15
-
Benni Mack commented on patch set 5 05/25/20, 15:32
PageTreeRepository.php:191Unresolveddo you know `array_column($pageRecords, 'uid');`PageTreeRepository.php:195UnresolvedI think we need some basic type casting here... $page['uid'] === 0 $pageId = (int)$page['uid']; and then roll with it in all the places used -
Benni Mack updated the commit message in patch set 6 05/25/20, 18:54
-
Tymoteusz Motylewski updated the commit message in patch set 7 05/26/20, 08:47
-
TYPO3com voted on patch set 7 V -1 05/26/20, 08:59 Completed build in 12m 05s on Tue, 26 May, 08:59 AM Test Summary: 2 of 74296 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3555
-
TYPO3com voted on patch set 7 V +1 05/26/20, 09:26 Completed build in 50m 49s on Tue, 26 May, 09:26 AM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3555
-
Richard Haeser uploaded patch set 8 05/26/20, 18:39
-
TYPO3com voted on patch set 8 V +1 05/26/20, 18:54 Completed build in 15m 16s on Tue, 26 May, 06:54 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3579
-
Richard Haeser voted on patch set 8 V +1 CR +1 05/26/20, 19:10
-
Uwe Trotzek commented on patch set 8 V +1 06/03/20, 15:25
I cannot reproduce the original issue but it doesn't break anything in my test instance so it looks good to me. -
Benni Mack voted on patch set 8 CR +2 06/03/20, 18:49
-
Richard Haeser commented on patch set 8 06/03/20, 19:23
> Patch Set 8: Verified+1 > > I cannot reproduce the original issue but it doesn't break anything in my test instance so it looks good to me. That is because there is no real issue in master but performance anymore. So this is purely a (slight) performance benefit. -
Richard Haeser voted on patch set 8 V +2 CR +2 06/03/20, 19:25
-
Richard Haeser merged patch set 9 06/03/20, 19:25
-
Uwe Trotzek commented on patch set 9 06/04/20, 05:53
> Patch Set 8: > > > Patch Set 8: Verified+1 > > > > I cannot reproduce the original issue but it doesn't break anything in my test instance so it looks good to me. > > That is because there is no real issue in master but performance anymore. So this is purely a (slight) performance benefit. Thanks for clarifying. Now I can see the slight performance benefit for users with restricted access to the page tree.
PageTreeRepository.php:166Unresolved