Review main Abandoned

64354Revert "[BUGFIX] Allow external images for FluidEmail image ViewHelpers"

Helmut Hummel CR 0 V 0 Normal +50 −70 updated 12/09/21, 00:56

Commit message

This reverts commit e6e40cd214acc8581729ef9f6e98c5d9324ec11c.

Reason for revert: Instead of using the image view helper and potentially triggereing FAL storage 0 compatiblity API, we should just use regular HTML tags.

Besides that, the introduced change does not provide same behaviour as LoginController, so we can't rely in FluidEmail on using the same configuration for logos anyway.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 810

  1. Helmut Hummel uploaded patch set 1 05/01/20, 22:35

  2. TYPO3com voted on patch set 1 V -1 05/01/20, 22:48 Completed build in 13m 00s on Fri, 1 May, 10:48 PM Test Summary: 1 of 74147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3157

  3. Benni Mack voted on patch set 1 CR +1 05/04/20, 07:36

  4. TYPO3com voted on patch set 1 V +1 05/04/20, 07:40 Completed build in 9h 18m 42s on Mon, 4 May, 07:40 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3157

  5. Benni Mack commented on patch set 1 CR -1 05/11/20, 07:15

    we need a Issue number and Releases line
  6. Jonas Eberle wrote 01/09/21, 13:00

    Removed reviewer Jonas Eberle.
  7. Benni Mack commented on patch set 1 11/03/21, 21:04

    Can we close this in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/64327 @helhum?
  8. Benni Mack wrote 11/29/21, 10:15

    Change destination moved from master to main
  9. Christian Kuhn commented on patch set 1 12/09/21, 00:56

    hey. abandoning. seems this has been mitigated by other patches.
  10. Christian Kuhn abandoned the change 12/09/21, 00:56