Review 9.5 Merged

64358[BUGFIX] Lift restriction for restricted records in Routing Aspects

Benni Mack CR +2 V +2 Easy +16 −4 updated 05/06/20, 10:10

Commit message

Since TYPO3 v9.5.16 it is not possible anymore to resolve URLs with an
Aspect that contains records with fe_group restrictions. This is due to
a legacy solution that the Frontend User is actually initialized early enough
but the groups are resolved within $TSFE->determineId() at a later point.

For this reason, Routing does not handle fe_group restrictions, but the
plugin should take care of that for the time being.

Future TYPO3 versions can decide to resolve the fe_group restrictions earlier,
but this would be a breaking change of behaviour of the Frontend
Request Workflow for TYPO3 v10 + v9.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 05/06/20, 09:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/06/20, 09:42 Completed build in 15m 21s on Wed, 6 May, 09:42 AM Test Summary: 74834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-574

  3. Benni Mack voted on patch set 1 V +2 CR +2 05/06/20, 10:10

  4. Benni Mack merged patch set 2 05/06/20, 10:10