Review 9.5 Merged

64359[BUGFIX] Use correct slug for access restricted translated pages

Benni Mack CR +2 V +2 Normal +80 −0 updated 05/06/20, 15:23

Commit message

Access restricted, translated pages currently always have the slug from the
default language instead of their translated slug in the frontend.
To generate correct urls, while using the "linkAccessRestrictedPages"
option, the $disableGroupAccessCheck parameter needs to also take into
account for
 * PageRepository::getPageOverlay()
when setting the option in PageRepository::getPage().

This "hack" is currently similar to what HMENU is doing, however
this public property should not be used with the Context API instead.

This change however needs more refactoring on the Context API,
which is why this solution is chosen for the time being (and also
for v9 backport).

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 05/06/20, 14:56

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php
  2. TYPO3com voted on patch set 1 V -1 05/06/20, 14:57 Completed build in 28s on Wed, 6 May, 02:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-577

  3. Benni Mack uploaded patch set 2 05/06/20, 15:00

  4. Benni Mack commented on patch set 2 05/06/20, 15:00

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 05/06/20, 15:14 Completed build in 13m 43s on Wed, 6 May, 03:14 PM Test Summary: 74859 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-578

  6. Benni Mack voted on patch set 2 V +2 CR +2 05/06/20, 15:23

  7. Benni Mack merged patch set 3 05/06/20, 15:23