Review 9.5 Merged

64365[BUGFIX] Fix HMENU special=directory when site language is in free mode

Benni Mack CR +2 V +2 Easy +16 −0 updated 05/11/20, 11:57

Commit message

When setting a site language into free mode for translations, then
"$cObj->exec_getQuery()" only returns the pages without overlays.
HMENU however always expects sys_language_uid=0 records, as it does a
MountPoint + overlay again. Doing an getPageOverlay of a translated page
results in an empty result.

The change now modifies the HMENU directory resolving
to fetch the original record (cached in PageRepository), and do
the overlay information as well.

This also fixes the same issue in HMENU.special = updated

Big Kudos to Jones for great support on tackling this issue!

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 05/11/20, 07:14

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 05/11/20, 07:27 Completed build in 12m 20s on Mon, 11 May, 07:27 AM Test Summary: 74861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-585

  3. Benni Mack voted on patch set 1 V +2 CR +2 05/11/20, 11:57

  4. Benni Mack merged patch set 2 05/11/20, 11:57