Review main Merged Breaking

64381[!!!][TASK] Remove deprecated web request class

Alexander Schnitzler CR +2 V +2 Normal +38 −56 updated 05/29/20, 20:20

Commit message

The Web request class is removed in favor of Extbase's
base request object.

For this change, the testing framework has to be adapted
to use the base request object instead of the Web request
object.

Used composer command:
  composer req "typo3/testing-framework:^6.3.2" --dev

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 21

Review log 1725

  1. Alexander Schnitzler uploaded patch set 1 05/01/20, 09:47

  2. Alexander Schnitzler wrote 05/01/20, 09:47

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V -1 05/01/20, 09:59 Completed build in 11m 44s on Fri, 1 May, 09:59 AM Test Summary: 1908 of 74147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3143

  4. Alexander Schnitzler commented on patch set 1 05/01/20, 10:08

    > Patch Set 1: Verified-1 > > Completed build in 11m 44s on Fri, 1 May, 09:59 AM > Test Summary: 1908 of 74147 failed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3143 breaks due to the usage of web request in the testing framework: https://github.com/TYPO3/testing-framework/blob/master/Classes/Fluid/Unit/ViewHelpers/ViewHelperBaseTestcase.php#L19
  5. Benni Mack uploaded patch set 2 05/29/20, 13:13

  6. Benni Mack commented on patch set 2 V +1 CR +1 05/29/20, 13:14

    This change is ready for review.
  7. TYPO3com voted on patch set 2 V -1 05/29/20, 13:29 Completed build in 15m 16s on Fri, 29 May, 01:29 PM Test Summary: 1908 of 73560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3631

  8. TYPO3com commented on patch set 2 05/29/20, 15:25 Completed build in 2h 26m 19s on Fri, 29 May, 03:24 PM Test Summary: 1908 of 73560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3631

  9. Andreas Kienast uploaded patch set 3 05/29/20, 15:49

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 05/29/20, 15:52

  11. TYPO3com voted on patch set 3 V -1 05/29/20, 16:09 Completed build in 15m 26s on Fri, 29 May, 04:09 PM Test Summary: 1908 of 73581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3639

  12. Wouter Wolters voted on patch set 3 V +1 CR +1 05/29/20, 17:57

  13. Benjamin Franzke commented on patch set 3 CR -1 05/29/20, 18:25

    Requires an update of the testing framework, vendor/typo3/testing-framework/Classes/Fluid/Unit/ViewHelpers/ViewHelperBaseTestcase.php still uses TYPO3\CMS\Extbase\Mvc\Web\Request::class as argument to prophecy. (this is actually causing the unit tests for the view helpers to fail)
  14. Benni Mack uploaded patch set 4 05/29/20, 18:30

  15. TYPO3com voted on patch set 4 V -1 05/29/20, 18:44 Completed build in 14m 38s on Fri, 29 May, 06:44 PM Test Summary: 73084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3641

  16. Benni Mack updated the commit message in patch set 5 05/29/20, 18:50

  17. TYPO3com commented on patch set 4 05/29/20, 18:54 Completed build in 39m 15s on Fri, 29 May, 06:54 PM Test Summary: 73094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3641

  18. TYPO3com voted on patch set 5 V -1 05/29/20, 19:09 Completed build in 14m 31s on Fri, 29 May, 07:09 PM Test Summary: 73093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3647

  19. Benni Mack uploaded patch set 6 05/29/20, 19:13

  20. TYPO3com voted on patch set 6 V +1 05/29/20, 19:25 Completed build in 11m 40s on Fri, 29 May, 07:25 PM Test Summary: 73094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3650

  21. Benni Mack voted on patch set 6 V +1 CR +1 05/29/20, 20:06

  22. Benjamin Franzke voted on patch set 6 V +1 CR +1 05/29/20, 20:15

  23. Wouter Wolters voted on patch set 6 V +1 CR +1 05/29/20, 20:18

  24. Benjamin Franzke voted on patch set 6 V +2 CR +2 05/29/20, 20:20

  25. Benjamin Franzke merged patch set 7 05/29/20, 20:20