64381[!!!][TASK] Remove deprecated web request class
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Wouter Wolters +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 21
- typo3/sysext/core/Documentation/Changelog/master/Breaking-91473-DeprecatedFunctionalityRemoved.rst+1 −0
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/extbase/Classes/Mvc/View/NotFoundView.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/ReferringRequest.php+2 −0
- typo3/sysext/extbase/Classes/Mvc/Web/Request.phpdeleted+0 −28
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+3 −2
- typo3/sysext/extbase/Classes/Mvc/Request.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+1 −1
- typo3/sysext/fluid/Classes/View/StandaloneView.php+2 −2
- typo3/sysext/fluid/Tests/Unit/Core/Widget/AbstractWidgetViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestHandlerTest.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+2 −2
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+2 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+6 −0
- composer.json+1 −1
Show 1 more file
Review log 1725
-
Alexander Schnitzler uploaded patch set 1 05/01/20, 09:47
-
Alexander Schnitzler wrote 05/01/20, 09:47
Topic set to extbase -
TYPO3com voted on patch set 1 V -1 05/01/20, 09:59 Completed build in 11m 44s on Fri, 1 May, 09:59 AM Test Summary: 1908 of 74147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3143
-
Alexander Schnitzler commented on patch set 1 05/01/20, 10:08
> Patch Set 1: Verified-1 > > Completed build in 11m 44s on Fri, 1 May, 09:59 AM > Test Summary: 1908 of 74147 failed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3143 breaks due to the usage of web request in the testing framework: https://github.com/TYPO3/testing-framework/blob/master/Classes/Fluid/Unit/ViewHelpers/ViewHelperBaseTestcase.php#L19 -
Benni Mack uploaded patch set 2 05/29/20, 13:13
-
Benni Mack commented on patch set 2 V +1 CR +1 05/29/20, 13:14
This change is ready for review. -
TYPO3com voted on patch set 2 V -1 05/29/20, 13:29 Completed build in 15m 16s on Fri, 29 May, 01:29 PM Test Summary: 1908 of 73560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3631
-
TYPO3com commented on patch set 2 05/29/20, 15:25 Completed build in 2h 26m 19s on Fri, 29 May, 03:24 PM Test Summary: 1908 of 73560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3631
-
Andreas Kienast uploaded patch set 3 05/29/20, 15:49
-
Andreas Kienast voted on patch set 3 V +1 CR +1 05/29/20, 15:52
-
TYPO3com voted on patch set 3 V -1 05/29/20, 16:09 Completed build in 15m 26s on Fri, 29 May, 04:09 PM Test Summary: 1908 of 73581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3639
-
Wouter Wolters voted on patch set 3 V +1 CR +1 05/29/20, 17:57
-
Benjamin Franzke commented on patch set 3 CR -1 05/29/20, 18:25
Requires an update of the testing framework, vendor/typo3/testing-framework/Classes/Fluid/Unit/ViewHelpers/ViewHelperBaseTestcase.php still uses TYPO3\CMS\Extbase\Mvc\Web\Request::class as argument to prophecy. (this is actually causing the unit tests for the view helpers to fail) -
Benni Mack uploaded patch set 4 05/29/20, 18:30
-
TYPO3com voted on patch set 4 V -1 05/29/20, 18:44 Completed build in 14m 38s on Fri, 29 May, 06:44 PM Test Summary: 73084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3641
-
Benni Mack updated the commit message in patch set 5 05/29/20, 18:50
-
TYPO3com commented on patch set 4 05/29/20, 18:54 Completed build in 39m 15s on Fri, 29 May, 06:54 PM Test Summary: 73094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3641
-
TYPO3com voted on patch set 5 V -1 05/29/20, 19:09 Completed build in 14m 31s on Fri, 29 May, 07:09 PM Test Summary: 73093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3647
-
Benni Mack uploaded patch set 6 05/29/20, 19:13
-
TYPO3com voted on patch set 6 V +1 05/29/20, 19:25 Completed build in 11m 40s on Fri, 29 May, 07:25 PM Test Summary: 73094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3650
-
Benni Mack voted on patch set 6 V +1 CR +1 05/29/20, 20:06
-
Benjamin Franzke voted on patch set 6 V +1 CR +1 05/29/20, 20:15
-
Wouter Wolters voted on patch set 6 V +1 CR +1 05/29/20, 20:18
-
Benjamin Franzke voted on patch set 6 V +2 CR +2 05/29/20, 20:20
-
Benjamin Franzke merged patch set 7 05/29/20, 20:20