64384[TASK] Use getElementById where feasible
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 2
Files 24
- Build/Sources/TypeScript/adminpanel/Resources/Public/TypeScript/AdminPanel.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/GroupElement.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/InputLinkElement.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectMultipleSideBySideElement.ts+2 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTreeElement.ts+2 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/TextElement.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/TextTableElement.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Notification.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ToggleSearchToolbox.ts5+1 −1
- Build/Sources/TypeScript/backend/Tests/NotificationTest.ts+1 −1
- Build/Sources/TypeScript/beuser/Resources/Public/TypeScript/BackendUserListing.ts1+1 −1
- Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/DashboardModal.ts+1 −1
- typo3/sysext/adminpanel/Resources/Public/JavaScript/AdminPanel.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/GroupElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/InputLinkElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectMultipleSideBySideElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/TextElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/TextTableElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Notification.js+1 −1
Show 4 more files
Review log 1517
-
Andreas Kienast uploaded patch set 1 05/01/20, 11:47
-
TYPO3com voted on patch set 1 V +1 05/01/20, 11:58 Completed build in 10m 53s on Fri, 1 May, 11:58 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3148
-
Georg Ringer commented on patch set 1 V +1 CR +1 05/04/20, 11:12
BackendUserListing.ts:24Unresolvedshouldn't this be kept? -
Andreas Kienast commented on patch set 1 05/04/20, 11:13
ToggleSearchToolbox.ts:41ReplyIt doesn't hurt to change it to getElementById() -
Benjamin Franzke commented on patch set 1 CR -1 05/04/20, 11:30
There is document.querySelector(`#dashboardModal-${this.dataset.modalIdentifier}`) left in Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/DashboardModal.ts And some document.querySelector('#' + …) calls in Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Container/InlineControlContainer.ts Those should be feasible as well. See: git grep "document.querySelector(.#" | grep -v "define(\|/Documentation -
Benjamin Franzke commented on patch set 1 05/04/20, 11:33
ToggleSearchToolbox.ts:41Reply@Georg: I'm wondering why you think that these should be kept? Because of the HTMLInputElement type assertion? -
Andreas Kienast commented on patch set 1 05/04/20, 11:35
> There is > > document.querySelector(`#dashboardModal-${this.dataset.modalIdentifier}`) > > left in Build/Sources/TypeScript/dashboard/Resources/Public/TypeScript/DashboardModal.ts Ack > And some document.querySelector('#' + …) calls in Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Container/InlineControlContainer.ts Those should've been fixed in another patch. Are you sure your checkout is up-to-date? Your command also reveals just the DashboardModal for me (thx by the way for providing this). -
Benjamin Franzke commented on patch set 1 05/04/20, 12:50
Ah, I see https://review.typo3.org/c/Packages/TYPO3.CMS/+/64343 fixed InlineControlContainer.ts and was merged in the meantime and I used `git checkout`, not `git cherry-pick`. Maybe you could also git-rebase when fixing DashboardModel.ts (to reflect the dependency of this patch to the one that has already been merged). -
Georg Ringer commented on patch set 1 05/04/20, 14:29
ToggleSearchToolbox.ts:41Replyyes reffering the "as HTMLInputElement" -
Andreas Kienast commented on patch set 1 05/04/20, 15:47
ToggleSearchToolbox.ts:41Reply UnresolvedI don't get what you want. the `as HTMLInputElement` is required here, otherwise the code won't compile due to type mismatches. -
Andreas Kienast uploaded patch set 2 05/04/20, 15:52
-
TYPO3com voted on patch set 2 V +1 05/04/20, 16:04 Completed build in 11m 38s on Mon, 4 May, 04:04 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3194
-
Benjamin Franzke voted on patch set 2 CR +1 05/05/20, 08:04
-
Daniel Goerz voted on patch set 2 CR +1 05/07/20, 16:41
-
Benjamin Franzke voted on patch set 2 V +1 05/08/20, 09:23
-
Daniel Goerz voted on patch set 2 V +2 CR +2 05/09/20, 13:00
-
Daniel Goerz merged patch set 3 05/09/20, 13:01
ToggleSearchToolbox.ts:41