Review main Merged

64388[BUGFIX] Fix detection of plugin name by action

Alexander Schnitzler CR +2 V +2 Normal +50 −6 updated 05/08/20, 17:32

Commit message

While switching from controller class aliases to fully
qualified controller class names (internally), the structure
of framework configuration slightly changed.

This unfortunately broke the detection of the plugin name
by action because the new structure had not been checked for.

Also, there was a unit test which hasn't been adjusted to the
new structure as well because it was simply overlooked.

With this patch the bug is fixed and the fix is also covered
again by a unit test.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Helmut Hummel +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1819

  1. Alexander Schnitzler uploaded patch set 1 05/02/20, 11:32

  2. Alexander Schnitzler wrote 05/02/20, 11:32

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V +1 05/02/20, 11:43 Completed build in 11m 10s on Sat, 2 May, 11:43 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3163

  4. Alexander Schnitzler commented on patch set 1 05/02/20, 11:47

    This change is ready for review.
  5. Helmut Hummel voted on patch set 1 CR +1 05/05/20, 14:57

  6. Daniel Goerz voted on patch set 1 V +1 CR +1 05/06/20, 08:13

  7. Susi Moog commented on patch set 1 05/08/20, 12:33

    A question on how this should work: I have (as the issue reporter) 2 plugins that allow the same action. When I use the f:link action view helper or similar and specify the action that both plugins can handle, I would have expected that the currently "rendering" plugin is taken - however, instead the first plugin found is used. Is that how it should work?
  8. Alexander Schnitzler commented on patch set 1 05/08/20, 12:35

    > Patch Set 1: > > A question on how this should work: I have (as the issue reporter) 2 plugins that allow the same action. When I use the f:link action view helper or similar and specify the action that both plugins can handle, I would have expected that the currently "rendering" plugin is taken - however, instead the first plugin found is used. Is that how it should work? Where do you see that the first plugin found is used?
  9. Susi Moog commented on patch set 1 05/08/20, 13:00

    > Patch Set 1: > > > Patch Set 1: > > > > A question on how this should work: I have (as the issue reporter) 2 plugins that allow the same action. When I use the f:link action view helper or similar and specify the action that both plugins can handle, I would have expected that the currently "rendering" plugin is taken - however, instead the first plugin found is used. Is that how it should work? > > Where do you see that the first plugin found is used? By testing.
  10. Susi Moog commented on patch set 1 05/08/20, 13:00

    > Patch Set 1: > > > Patch Set 1: > > > > > Patch Set 1: > > > > > > A question on how this should work: I have (as the issue reporter) 2 plugins that allow the same action. When I use the f:link action view helper or similar and specify the action that both plugins can handle, I would have expected that the currently "rendering" plugin is taken - however, instead the first plugin found is used. Is that how it should work? > > > > Where do you see that the first plugin found is used? > > By testing. How should it work?
  11. Alexander Schnitzler commented on patch set 1 CR -1 05/08/20, 13:28

    > Patch Set 1: > > > Patch Set 1: > > > > > Patch Set 1: > > > > > > > Patch Set 1: > > > > > > > > A question on how this should work: I have (as the issue reporter) 2 plugins that allow the same action. When I use the f:link action view helper or similar and specify the action that both plugins can handle, I would have expected that the currently "rendering" plugin is taken - however, instead the first plugin found is used. Is that how it should work? > > > > > > Where do you see that the first plugin found is used? > > > > By testing. > > How should it work? Good question. I guess it should use the current plugin. Let's put a -1 for now and I have a look later. Can you summarize your test setup shortly? The plugin registration should suffice.
  12. Daniel Goerz voted on patch set 1 V 0 CR 0 05/08/20, 13:34

  13. Susi Moog commented on patch set 1 05/08/20, 16:29

    > Patch Set 1: Code-Review-1 > > Good question. I guess it should use the current plugin. Let's put a -1 for now and I have a look later. Can you summarize your test setup shortly? The plugin registration should suffice. Like this?: \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin( 'Susanne.Horst', 'Hildegard', [\Susanne\Horst\Controller\MuttiController::class => 'show,list'], [] ); \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin( 'Susanne.Horst', 'Hannelore', [\Susanne\Horst\Controller\MuttiController::class => 'index,list,show'], [] );
  14. Alexander Schnitzler wrote 05/08/20, 17:15

    Removed Code-Review-1 by Alexander Schnitzler <git@alexanderschnitzler.de>
  15. Susi Moog commented on patch set 1 V +1 05/08/20, 17:18

    PEBKAC - clearing the correct caches would have helped, sorry about the confusion.
  16. Susi Moog voted on patch set 1 CR +1 05/08/20, 17:18

  17. Alexander Schnitzler commented on patch set 1 05/08/20, 17:28

    > Patch Set 1: Verified+1 > > PEBKAC - clearing the correct caches would have helped, sorry about the confusion. nevermind, a second personal verification is a good thing. :)
  18. Daniel Goerz commented on patch set 1 V +2 CR +2 05/08/20, 17:30

    Alright, then we are good to go :)
  19. Daniel Goerz merged patch set 2 05/08/20, 17:32