Review 9.5 Merged

64392[TASK] Use proper function reference for backend route in test case

Oliver Hader CR +2 V +2 Easy +1 −4 updated 05/06/20, 08:59

Commit message

Invoking `call_user_func_array([ExampleClass::class, 'methodName'], [])`
on a non-static method throws a PHP warning. The function reference is
declared static as `ExampleClass::class . '::methodName'` and  changed
internally to a proper callable reference like
`[new ExampleClass(), 'methodName']`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Oliver Hader uploaded patch set 1 05/03/20, 09:53

  2. TYPO3com voted on patch set 1 V +1 05/03/20, 10:05 Completed build in 12m 25s on Sun, 3 May, 10:05 AM Test Summary: 74834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-557

  3. Oliver Klee voted on patch set 1 CR +1 05/03/20, 10:23

  4. Andreas Kienast commented on patch set 1 05/03/20, 13:45

    RouteDispatcherTest.php:95

    mainAction in RouteDispatcherClassFixture is not static for me. Do I miss something?
  5. Oliver Hader updated the commit message in patch set 2 05/04/20, 11:42

  6. Oliver Hader commented on patch set 2 05/04/20, 11:43

    RouteDispatcherTest.php:95 Reply Unresolved

    Patch is correct, but commit message was misleading and wrong...
  7. TYPO3com voted on patch set 2 V +1 05/04/20, 11:55 Completed build in 13m 04s on Mon, 4 May, 11:55 AM Test Summary: 74833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-562

  8. Oliver Hader voted on patch set 2 V +2 CR +2 05/06/20, 08:58

  9. Oliver Hader merged patch set 3 05/06/20, 08:59