Review main Merged

64393[BUGFIX] Respect disabled flag in render method of LinkButton

Frank Nägler CR +2 V +2 Easy +4 −0 updated 05/06/20, 14:53

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Josef Glatz +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Frank Nägler uploaded patch set 1 05/03/20, 10:46

  2. TYPO3com voted on patch set 1 V +1 05/03/20, 10:58 Completed build in 11m 11s on Sun, 3 May, 10:58 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3172

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 05/03/20, 11:16

  4. Andreas Kienast commented on patch set 1 V -1 CR 0 05/03/20, 11:20

    Setting the "disabled" attribute doesn't suffice, it's still possible to click the button. We have to add the "disabled" class as well.
  5. Andreas Kienast uploaded patch set 2 05/03/20, 11:22

  6. TYPO3com voted on patch set 2 V +1 05/03/20, 11:33 Completed build in 11m 39s on Sun, 3 May, 11:33 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3175

  7. Guido Schmechel voted on patch set 2 CR +1 05/03/20, 15:43

  8. Josef Glatz voted on patch set 2 V +1 CR +1 05/04/20, 14:14

  9. Daniel Goerz uploaded patch set 3 05/06/20, 12:35

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 05/06/20, 12:35

  11. TYPO3com voted on patch set 3 V +1 05/06/20, 12:46 Completed build in 11m 13s on Wed, 6 May, 12:46 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3231

  12. Josef Glatz voted on patch set 3 CR +1 05/06/20, 13:48

  13. Josef Glatz voted on patch set 3 V +1 05/06/20, 14:45

  14. Georg Ringer voted on patch set 3 V +2 CR +2 05/06/20, 14:53

  15. Georg Ringer merged patch set 4 05/06/20, 14:53