Review main Merged

64397[BUGFIX] Make rendering of priority option optional in XML sitemaps

Georg Ringer CR +2 V +2 Easy +3 −1 updated 05/05/20, 06:35

Commit message

According to https://www.sitemaps.org/de/protocol.html the option
`priority` is optional. If a SitemapProvider doesn't provide a priority
information the tag must be avoided to have a valid XML structure.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Andreas Kienast +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Georg Ringer uploaded patch set 1 05/04/20, 07:59

  2. Georg Ringer commented on patch set 1 05/04/20, 07:59

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 05/04/20, 08:10 Completed build in 11m 22s on Mon, 4 May, 08:10 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3179

  4. Richard Haeser voted on patch set 1 CR +1 05/04/20, 08:44

  5. Christian Eßl voted on patch set 1 V +1 CR +1 05/04/20, 09:00

  6. Andreas Kienast voted on patch set 1 CR +1 05/04/20, 09:17

  7. Josef Glatz voted on patch set 1 V +1 CR +1 05/04/20, 09:45

  8. Oli Bartsch voted on patch set 1 V +1 CR +1 05/04/20, 18:42

  9. Richard Haeser voted on patch set 1 V +2 CR +2 05/05/20, 06:30

  10. Richard Haeser merged patch set 2 05/05/20, 06:30

  11. Richard Haeser commented on patch set 2 05/05/20, 06:35

    Setting the priority is not possible in v9, so this won't be backported. If needed, you can override the XML template.