Review 9.5 Merged

64400[BUGFIX] Harden deprecation log handling

Benjamin Franzke CR +2 V +2 Normal +63 −3 updated 05/04/20, 11:13

Commit message

Because TYPO3's DefaultConfiguration is recursively
merged with settings from LocalConfiguration, it was
impossible to change or remove log writers that are
defined in DefaultConfiguration. One would have had
to use AdditionalConfiguration for that.

A simpler way to disable individual log writers is added now.
It is simpler, because it allows to disable log writers
directly in LocalConfiguration.

To avoid misconfiguration regarding deprecation logging,
E_USER_DEPRECATED is now enforced in SYS/errorHandlerErrors.

E_USER_DEPRECATED needs to be enforced to avoid,
that the default PHP error handler is called, which would cause
these errors to be added to the output or filling up log files,
depending on the global PHP configuration (php.ini).

Because all other values from DefaultConfiguration.php resemble
production settings and logging deprecation messages in production
are not desired, the deprecation logger is now disabled by default.

Last but not least, deprecation logging is now enabled/disabled in
the Live and Debug presets in the install tool UI.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 3

Files 7

Review log 23

  1. Benjamin Franzke uploaded patch set 1 05/04/20, 10:59

  2. TYPO3com voted on patch set 1 V +1 05/04/20, 11:11 Completed build in 12m 33s on Mon, 4 May, 11:11 AM Test Summary: 74834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-560

  3. Benjamin Franzke merged patch set 2 05/04/20, 11:13