64401[TASK] Add rel="noreferrer" to external links of widgets
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Josef Glatz +1
- Oli Bartsch +1
-
Verified V +2 Done
- Richard Haeser +2
- Josef Glatz +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/dashboard/Resources/Private/Partials/Widget/Button.html4new+5 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/ChartWidget.html+1 −5
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/CtaWidget.html+2 −4
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/ListWidget.html+2 −4
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/RssWidget.html+3 −5
Review log 1726
Show 1 earlier messages
-
Chris Müller uploaded patch set 1 05/04/20, 11:14
-
TYPO3com voted on patch set 1 V -1 05/04/20, 11:26 Completed build in 11m 23s on Mon, 4 May, 11:26 AM Test Summary: 73350 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3185
-
TYPO3com commented on patch set 1 05/04/20, 11:40 Completed build in 12m 40s on Mon, 4 May, 11:40 AM Test Summary: 1 of 74148 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3186
-
TYPO3com voted on patch set 1 V +1 05/04/20, 12:00 Completed build in 16m 42s on Mon, 4 May, 12:00 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3187
-
Josef Glatz commented on patch set 1 05/04/20, 12:09
Are these links always to be treated as external links? -
Chris Müller commented on patch set 1 05/04/20, 12:36
> Patch Set 1: > > Are these links always to be treated as external links? You are right, the rel is only necessary when target="_blank" is defined. Will provide another patch set. -
Chris Müller uploaded patch set 2 05/04/20, 12:40
-
TYPO3com voted on patch set 2 V -1 05/04/20, 12:52 Completed build in 12m 00s on Mon, 4 May, 12:52 PM Test Summary: 1 of 74148 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3188
-
TYPO3com commented on patch set 2 05/04/20, 13:05 Completed build in 11m 11s on Mon, 4 May, 01:05 PM Test Summary: 2 of 74148 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3189
-
TYPO3com commented on patch set 2 05/04/20, 13:20 Completed build in 12m 44s on Mon, 4 May, 01:20 PM Test Summary: 1 of 74147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3190
-
TYPO3com voted on patch set 2 V +1 05/04/20, 13:36 Completed build in 13m 21s on Mon, 4 May, 01:36 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3191
-
Josef Glatz commented on patch set 2 05/04/20, 14:32
Button.html:3Is it semantically/HTMLish O.K. to render also an empty target attribute? Because the target can also be empty?! -
Oli Bartsch commented on patch set 2 05/04/20, 14:36
Button.html:3ReplyIf not, could be: {f:if(condition: button.target, then: 'target="\'{button-target}\'"')} -
Josef Glatz commented on patch set 2 05/04/20, 14:50
Button.html:3ReplyTested an empty target in a link in mulitple browsers. Seems like it's technically OK to add an empty target attribute. But if we make them optionally rendered it would be fine. -
Richard Haeser commented on patch set 2 05/04/20, 15:07
Button.html:3Reply UnresolvedPersonally I prefer to not render the target attribute if no target is set. -
Chris Müller uploaded patch set 3 05/04/20, 16:47
-
TYPO3com voted on patch set 3 V +1 05/04/20, 16:59 Completed build in 11m 14s on Mon, 4 May, 04:59 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3196
-
Oli Bartsch commented on patch set 3 CR -1 05/04/20, 18:39
I don't like accessing variables which might not be initialised. I see it's bit more clean than two inline if clauses but as said. We are not sure if `target` or `rel` exists at all. -
Richard Haeser uploaded patch set 4 05/05/20, 06:57
-
Richard Haeser voted on patch set 4 V +1 CR +1 05/05/20, 06:58
-
Josef Glatz commented on patch set 4 CR +1 05/05/20, 07:02
Looks goo -
TYPO3com voted on patch set 4 V +1 05/05/20, 07:09 Completed build in 11m 39s on Tue, 5 May, 07:09 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3200
-
Josef Glatz voted on patch set 4 V +1 05/05/20, 07:10
-
Oli Bartsch voted on patch set 4 V +1 CR +1 05/05/20, 08:21
-
Richard Haeser voted on patch set 4 V +2 CR +2 05/05/20, 08:28
-
Richard Haeser merged patch set 5 05/05/20, 08:28