Review main Merged

64403[BUGFIX] Enable Enhancer support for MountPoints

Benni Mack CR +2 V +2 Easy +15 −1 updated 05/11/20, 20:14

Commit message

When using e.g. PageTypeDecorator in conjunction with mountpoints
and other Enhancers, the MP parameter was not added to the
resulting PageArguments object.

In addition, when building up a RouteCollection internally, the
same page was used multiple times but was overridden with a
MountPoint argument, adding to the "last principle wins" concept.

The patch adapts the needed changes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jan Kornblum +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jan Kornblum +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Benni Mack uploaded patch set 1 05/04/20, 14:47

  2. TYPO3com voted on patch set 1 V -1 05/04/20, 15:00 Completed build in 12m 29s on Mon, 4 May, 03:00 PM Test Summary: 12 of 74147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3192

  3. Benni Mack uploaded patch set 2 05/04/20, 15:28

  4. Jan Kornblum voted on patch set 2 V +1 CR +1 05/04/20, 15:30

  5. TYPO3com voted on patch set 2 V +1 05/04/20, 15:41 Completed build in 13m 17s on Mon, 4 May, 03:41 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3193

  6. Oliver Hader voted on patch set 2 V +1 CR +1 05/11/20, 19:55

  7. Benni Mack voted on patch set 2 V +2 CR +2 05/11/20, 20:14

  8. Benni Mack merged patch set 3 05/11/20, 20:14