Review main Merged

64405[BUGFIX] Fix URLs to RSS feeds in Dashboard Widgets

Richard Haeser CR +2 V +2 Easy +2 −2 updated 05/05/20, 14:13

Commit message

As the www prefix is not used anymore on typo3.org, the
URLs of the RSS feeds are updated in the Dashboard Widgets.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Josef Glatz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Richard Haeser uploaded patch set 1 05/04/20, 21:33

  2. TYPO3com voted on patch set 1 V +1 05/04/20, 21:45 Completed build in 11m 59s on Mon, 4 May, 09:45 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3197

  3. Josef Glatz updated the commit message in patch set 2 05/05/20, 05:22

  4. Josef Glatz voted on patch set 2 V +1 CR +1 05/05/20, 05:22

  5. TYPO3com voted on patch set 2 V +1 05/05/20, 05:34 Completed build in 12m 01s on Tue, 5 May, 05:34 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3198

  6. Josef Glatz commented on patch set 2 05/05/20, 06:16

    DashboardWidgets.yaml:180

    T3O side: Is it save to use human readable urls for page types? Maybe we can add tests on t3o side to check whether a feed urls is available via human readable url
  7. Thomas Löffler commented on patch set 2 CR +1 05/05/20, 06:27

    DashboardWidgets.yaml:180 Reply

    It's safer to use the HR urls than the type parameter. The type numbers could be changed, the HR urls not. Tests are prepared, I can add this test as well.
  8. Josef Glatz updated the commit message in patch set 3 05/05/20, 06:35

  9. Josef Glatz voted on patch set 3 V +1 CR +1 05/05/20, 06:35

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 05/05/20, 06:41

  11. TYPO3com voted on patch set 3 V +1 05/05/20, 06:49 Completed build in 13m 09s on Tue, 5 May, 06:49 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3199

  12. Richard Haeser voted on patch set 3 V +2 CR +2 05/05/20, 07:02

  13. Richard Haeser merged patch set 4 05/05/20, 07:02

  14. Josef Glatz commented on patch set 4 05/05/20, 14:13

    DashboardWidgets.yaml:180 Reply

    Cool, thanks Thomas!