Review main Merged

64408[BUGFIX] Lift restriction for restricted records in Routing Aspects

Benni Mack CR +2 V +2 Easy +16 −4 updated 05/06/20, 09:27

Commit message

Since TYPO3 v9.5.16 it is not possible anymore to resolve URLs with an
Aspect that contains records with fe_group restrictions. This is due to
a legacy solution that the Frontend User is actually initialized early enough
but the groups are resolved within $TSFE->determineId() at a later point.

For this reason, Routing does not handle fe_group restrictions, but the
plugin should take care of that for the time being.

Future TYPO3 versions can decide to resolve the fe_group restrictions earlier,
but this would be a breaking change of behaviour of the Frontend
Request Workflow for TYPO3 v10 + v9.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Krystian Szymukowicz +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 811

  1. Benni Mack uploaded patch set 1 05/05/20, 13:28

  2. TYPO3com voted on patch set 1 V -1 05/05/20, 13:39 Completed build in 11m 04s on Tue, 5 May, 01:39 PM Test Summary: 26 of 74147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3207

  3. Benni Mack uploaded patch set 2 05/05/20, 13:44

  4. TYPO3com voted on patch set 2 V -1 05/05/20, 13:55 Completed build in 10m 50s on Tue, 5 May, 01:55 PM Test Summary: 1 of 73826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3209

  5. TYPO3com voted on patch set 2 V +1 05/05/20, 15:04 Completed build in 1h 30m 49s on Tue, 5 May, 03:04 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3209

  6. Markus Klein voted on patch set 2 CR +1 05/05/20, 18:52

  7. Krystian Szymukowicz commented on patch set 2 V +1 05/05/20, 22:38

    I just tested the fix and I can confirm it works as expected.
  8. Oliver Hader voted on patch set 2 CR +1 05/06/20, 08:22

  9. Oliver Hader commented on patch set 2 V +1 05/06/20, 08:50

    Tested in v9 as well
  10. Benni Mack voted on patch set 2 V +2 CR +2 05/06/20, 09:27

  11. Benni Mack merged patch set 3 05/06/20, 09:27