Review main Merged

64409[BUGFIX] Correctly consider nested tags in frontend HTML parser

Oliver Hader CR +2 V +2 Hard +116 −161 updated 05/08/20, 12:16

Commit message

Nested tags starting with the same literals, like `<s><span>...`
or `<a ...><abbr>...` are not correctly nested due to a flaw in
identifying proper start and end of HTML tags.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Markus Klein +1
    • Oliver Hader +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Susi Moog +2
    • Markus Klein +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Oliver Hader uploaded patch set 1 05/05/20, 13:31

  2. TYPO3com voted on patch set 1 V -1 05/05/20, 13:31 Completed build in 28s on Tue, 5 May, 01:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3208

  3. Oliver Hader uploaded patch set 2 05/05/20, 14:25

  4. TYPO3com voted on patch set 2 V -1 05/05/20, 14:37 Completed build in 11m 37s on Tue, 5 May, 02:37 PM Test Summary: 1 of 74153 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3210

  5. TYPO3com voted on patch set 2 V +1 05/05/20, 14:42 Completed build in 28m 45s on Tue, 5 May, 02:42 PM Test Summary: 73669 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3210

  6. Markus Klein voted on patch set 2 CR +1 05/05/20, 14:42

  7. Helmut Hummel voted on patch set 2 CR +1 05/05/20, 14:46

  8. Daniel Goerz voted on patch set 2 CR +1 05/06/20, 08:28

  9. Oliver Hader voted on patch set 2 V +1 CR +1 05/06/20, 08:53

  10. Markus Klein voted on patch set 2 V +1 05/06/20, 11:02

  11. Susi Moog voted on patch set 2 V +2 CR +2 05/08/20, 12:15

  12. Susi Moog merged patch set 3 05/08/20, 12:16