Review main Merged

64411[BUGFIX] Fix internal + external links with URLs fragment

Benni Mack CR +2 V +2 Easy +12 −4 updated 05/12/20, 07:17

Commit message

Internal and external links have been incorrectly processed
by the legacy link notation converter which removed the
fragment from the URL before checking whether
the link is actually a legacy (file) link.

The change is now narrowed down to only append the fragment to
file links.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 1121

  1. Benni Mack uploaded patch set 1 05/05/20, 14:58

  2. TYPO3com voted on patch set 1 V -1 05/05/20, 15:11 Completed build in 12m 39s on Tue, 5 May, 03:11 PM Test Summary: 486 of 74079 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3213

  3. Benni Mack uploaded patch set 2 05/05/20, 15:54

  4. TYPO3com voted on patch set 2 V -1 05/05/20, 16:06 Completed build in 12m 22s on Tue, 5 May, 04:06 PM Test Summary: 171 of 74159 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3215

  5. Benni Mack uploaded patch set 3 05/06/20, 15:12

  6. TYPO3com voted on patch set 3 V -1 05/06/20, 15:25 Completed build in 13m 13s on Wed, 6 May, 03:25 PM Test Summary: 123 of 73876 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3235

  7. Benni Mack uploaded patch set 4 05/09/20, 09:12

  8. TYPO3com voted on patch set 4 V -1 05/09/20, 09:27 Completed build in 14m 34s on Sat, 9 May, 09:27 AM Test Summary: 117 of 74213 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3279

  9. Benni Mack uploaded patch set 5 05/11/20, 15:29

  10. TYPO3com voted on patch set 5 V -1 05/11/20, 15:30 Completed build in 24s on Mon, 11 May, 03:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3305

  11. Benni Mack uploaded patch set 6 05/11/20, 19:23

  12. TYPO3com voted on patch set 6 V -1 05/11/20, 19:36 Completed build in 13m 00s on Mon, 11 May, 07:36 PM Test Summary: 108 of 74222 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3309

  13. Benni Mack uploaded patch set 7 05/11/20, 19:45

  14. Benni Mack updated the commit message in patch set 8 05/11/20, 19:46

  15. TYPO3com voted on patch set 7 V +1 05/11/20, 19:58 Completed build in 13m 05s on Mon, 11 May, 07:58 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3312

  16. TYPO3com voted on patch set 8 V +1 05/11/20, 20:04 Completed build in 16m 44s on Mon, 11 May, 08:04 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3313

  17. Benjamin Franzke uploaded patch set 9 05/12/20, 05:18

  18. TYPO3com voted on patch set 9 V -1 05/12/20, 05:30 Completed build in 11m 49s on Tue, 12 May, 05:30 AM Test Summary: 1 of 74189 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3320

  19. TYPO3com voted on patch set 9 V +1 05/12/20, 06:57 Completed build in 1h 50m 46s on Tue, 12 May, 06:57 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3320

  20. Benni Mack voted on patch set 9 V +2 CR +2 05/12/20, 07:17

  21. Benni Mack merged patch set 10 05/12/20, 07:17