64413[BUGFIX] Do not set type=text/javascript in ResourceCompressor
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 68
-
Benni Mack uploaded patch set 1 05/05/20, 18:50
-
Benni Mack updated the commit message in patch set 2 05/05/20, 18:50
-
Raphael Zschorsch commented on patch set 2 05/05/20, 18:53
Should't we check the config.doctype here as well, instead of removing the text/javascript completely without a fallback? -
Benni Mack commented on patch set 2 05/05/20, 18:59
> Patch Set 2: > > Should't we check the config.doctype here as well, instead of removing the text/javascript completely without a fallback? good point. want to give it a try? -
TYPO3com voted on patch set 1 V +1 05/05/20, 19:02 Completed build in 12m 01s on Tue, 5 May, 07:02 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3217
-
TYPO3com voted on patch set 2 V +1 05/05/20, 19:08 Completed build in 15m 22s on Tue, 5 May, 07:08 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3218
-
Markus Klein commented on patch set 2 CR -1 05/05/20, 19:45
Raphael pushed a new version to https://review.typo3.org/c/Packages/TYPO3.CMS/+/64414 -
Benni Mack abandoned the change 05/06/20, 15:24
let's use the other one