Review main Merged

64414[BUGFIX] Do not set type=text/javascript in ResourceCompressor

Raphael Zschorsch CR +2 V +2 Easy +24 −1 updated 08/15/20, 15:15

Commit message

The ResourceCompressor should not hard-code the JS file
type when concatenating JS files.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2429

Show 34 earlier messages
  1. Raphael Zschorsch uploaded patch set 1 05/05/20, 19:32

  2. TYPO3com voted on patch set 1 V -1 05/05/20, 19:44 Completed build in 11m 34s on Tue, 5 May, 07:44 PM Test Summary: 42 of 74147 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3219

  3. Markus Klein commented on patch set 1 05/05/20, 19:45

    ResourceCompressor.php:22

    I'm not so sure if I like this change so much, because now we introduced a reverse dependency from ext:core to ext:frontend
  4. Raphael Zschorsch commented on patch set 1 05/07/20, 18:46

    Sorry for the new review - it was my first time, trying to fix something in the core. So I don't really know where to go from here now and what is best practice.
  1. Markus Klein commented on patch set 1 05/07/20, 19:22

    > Patch Set 1: > > Sorry for the new review - it was my first time, trying to fix something in the core. So I don't really know where to go from here now and what is best practice. Don't worry. Everyone had his/her first time. ;-) Thanks for your contribution!
  2. Helmut Hummel commented on patch set 1 05/10/20, 12:32

    ResourceCompressor.php:22 Reply Unresolved

    I agree. ResourceCompressor can also be used in backend context
  3. Raphael Zschorsch commented on patch set 1 05/13/20, 10:19

    Okay, so where to go from here? Because this feature is currently not working as expected, because of the hardcoded text/javascript: https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.0/Breaking-88772-JavaScriptScriptTagsOmitTypetextjavascriptInHTML5.html
  4. Markus Klein commented on patch set 1 05/13/20, 11:35

    > Patch Set 1: > > Okay, so where to go from here? Because this feature is currently not working as expected, because of the hardcoded text/javascript: https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.0/Breaking-88772-JavaScriptScriptTagsOmitTypetextjavascriptInHTML5.html I think about it this way: Why not removing the type completely? What application really need the mime-type? Current browsers all assume JS if no mime-type is provided, even if it's not HTML5.
  5. Benni Mack updated the commit message in patch set 2 05/25/20, 18:51

  6. Benni Mack uploaded patch set 3 06/04/20, 19:25

  7. Benni Mack voted on patch set 3 V +1 CR +1 06/04/20, 19:26

  8. TYPO3com voted on patch set 3 V -1 06/04/20, 20:12 Completed build in 29m 07s on Thu, 4 Jun, 08:12 PM Test Summary: 42 of 73317 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3838

  9. Markus Klein commented on patch set 3 06/05/20, 09:18

    ResourceCompressor.php:189 Unresolved

    besides the failing tests we still do not solve the issue that for BE usage (which is html5) we still generate the type. \TYPO3\CMS\Backend\Template\ModuleTemplate enables the concatenation by default
  10. Benni Mack uploaded patch set 4 08/07/20, 10:24

  11. TYPO3com voted on patch set 4 V +1 08/07/20, 10:36 Completed build in 12m 26s on Fri, 7 Aug, 10:36 AM Test Summary: 72983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4468

  12. Benni Mack voted on patch set 4 V +1 CR +1 08/07/20, 15:39

  13. Markus Klein commented on patch set 4 08/10/20, 06:44

    ResourceCompressor.php:713 Unresolved

    If some BE module has to create a fake FE (we actually need that quite often) then this condition would not match as we have a TSFE then. Would TYPO3_MODE==BE (or a newer version of it) be more appropriate?
  14. Benni Mack commented on patch set 5 08/10/20, 12:50

    Published edit on patch set 4.
  15. TYPO3com voted on patch set 5 V +1 08/10/20, 13:02 Completed build in 12m 07s on Mon, 10 Aug, 01:02 PM Test Summary: 72967 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4547

  16. Markus Klein voted on patch set 5 CR +1 08/10/20, 14:30

  17. Benni Mack voted on patch set 5 V +1 CR +1 08/10/20, 16:10

  18. Georg Ringer commented on patch set 5 CR -1 08/10/20, 17:24

    ResourceCompressor.php:714 Unresolved

    either remove the comment or adopt it regarding tsfe, same with method comment

    ResourceCompressor.php:717 Unresolved

    default value is html5, checkout TSFE which does it this way ---- $doctype = $this->config['config']['doctype'] ?? 'html5'; ---- so please use this here as well
  19. Markus Klein commented on patch set 6 08/11/20, 07:31

    Published edit on patch set 5.
  20. Markus Klein voted on patch set 6 CR +1 08/11/20, 07:31

  21. TYPO3com voted on patch set 6 V +1 08/11/20, 07:43 Completed build in 11m 30s on Tue, 11 Aug, 07:43 AM Test Summary: 72989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4562

  22. Benni Mack voted on patch set 6 V +1 CR +1 08/14/20, 10:19

  23. Christian Kuhn voted on patch set 6 V +1 CR +1 08/15/20, 15:15

  24. Anja Leichsenring voted on patch set 6 V +2 CR +2 08/15/20, 15:15

  25. Anja Leichsenring merged patch set 7 08/15/20, 15:15