64415[BUGFIX] Change 3rd argument of calls to callUserFunction()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josef Glatz +1
- Markus Klein +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Josef Glatz +1
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1720
-
Georg Ringer uploaded patch set 1 05/05/20, 20:01
-
Georg Ringer commented on patch set 1 05/05/20, 20:02
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 05/05/20, 20:13 Completed build in 12m 07s on Tue, 5 May, 08:13 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3220
-
Markus Klein updated the commit message in patch set 2 05/05/20, 20:56
-
Markus Klein voted on patch set 2 CR +1 05/05/20, 21:04
-
Markus Klein voted on patch set 2 V +1 05/05/20, 21:05
-
TYPO3com voted on patch set 2 V +1 05/05/20, 21:08 Completed build in 11m 09s on Tue, 5 May, 09:08 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3223
-
Josef Glatz commented on patch set 2 CR +1 05/06/20, 05:04
Found some other places in the core where exactly this is also set to false beforehand (by reading). Is that patch meant for all wrong occurrences? -
Josef Glatz commented on patch set 2 05/06/20, 05:04
> Patch Set 2: Code-Review+1 > > Found some other places in the core where exactly this is also set to false beforehand (by reading). Is that patch meant for all wrong occurrences? searched in v9.5 -
Josef Glatz commented on patch set 2 V +1 05/06/20, 05:10
> Patch Set 2: > > > Patch Set 2: Code-Review+1 > > > > Found some other places in the core where exactly this is also set to false beforehand (by reading). Is that patch meant for all wrong occurrences? > > searched in v9.5 forget my comment. The responsible change was only made in master! -
Josef Glatz commented on patch set 2 V 0 CR -1 05/06/20, 05:23
will push update -
Josef Glatz uploaded patch set 3 05/06/20, 05:51
-
Josef Glatz voted on patch set 3 V +1 CR +1 05/06/20, 05:52
-
TYPO3com voted on patch set 3 V +1 05/06/20, 06:08 Completed build in 15m 57s on Wed, 6 May, 06:08 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3225
-
Benni Mack commented on patch set 3 05/06/20, 06:31
@Alex - can't rector fix this as well? I mean, it showed us this change in the first place. -
Andreas Kienast voted on patch set 3 CR +1 05/06/20, 06:33
-
Markus Klein voted on patch set 3 V +1 CR +1 05/06/20, 07:22
-
Alexander Schnitzler commented on patch set 3 05/06/20, 07:35
@Benni phpstan showed us the need for a change, not rector. I guess we could write a rector for an automatic update but since this patch is finished, I don't see it being worth it anymore. -
Benni Mack voted on patch set 3 V +2 CR +2 05/06/20, 11:17
-
Benni Mack merged patch set 4 05/06/20, 11:17