Review main Merged

64415[BUGFIX] Change 3rd argument of calls to callUserFunction()

Georg Ringer CR +2 V +2 Easy +5 −5 updated 05/06/20, 11:17

Commit message

The third argument of `GeneralUtility::callUserFunction` must be either
an object or null.
Ensure the argument is always null instead of false to avoid
triggering a deprecation log entry.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1720

  1. Georg Ringer uploaded patch set 1 05/05/20, 20:01

  2. Georg Ringer commented on patch set 1 05/05/20, 20:02

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 05/05/20, 20:13 Completed build in 12m 07s on Tue, 5 May, 08:13 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3220

  4. Markus Klein updated the commit message in patch set 2 05/05/20, 20:56

  5. Markus Klein voted on patch set 2 CR +1 05/05/20, 21:04

  6. Markus Klein voted on patch set 2 V +1 05/05/20, 21:05

  7. TYPO3com voted on patch set 2 V +1 05/05/20, 21:08 Completed build in 11m 09s on Tue, 5 May, 09:08 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3223

  8. Josef Glatz commented on patch set 2 CR +1 05/06/20, 05:04

    Found some other places in the core where exactly this is also set to false beforehand (by reading). Is that patch meant for all wrong occurrences?
  9. Josef Glatz commented on patch set 2 05/06/20, 05:04

    > Patch Set 2: Code-Review+1 > > Found some other places in the core where exactly this is also set to false beforehand (by reading). Is that patch meant for all wrong occurrences? searched in v9.5
  10. Josef Glatz commented on patch set 2 V +1 05/06/20, 05:10

    > Patch Set 2: > > > Patch Set 2: Code-Review+1 > > > > Found some other places in the core where exactly this is also set to false beforehand (by reading). Is that patch meant for all wrong occurrences? > > searched in v9.5 forget my comment. The responsible change was only made in master!
  11. Josef Glatz commented on patch set 2 V 0 CR -1 05/06/20, 05:23

    will push update
  12. Josef Glatz uploaded patch set 3 05/06/20, 05:51

  13. Josef Glatz voted on patch set 3 V +1 CR +1 05/06/20, 05:52

  14. TYPO3com voted on patch set 3 V +1 05/06/20, 06:08 Completed build in 15m 57s on Wed, 6 May, 06:08 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3225

  15. Benni Mack commented on patch set 3 05/06/20, 06:31

    @Alex - can't rector fix this as well? I mean, it showed us this change in the first place.
  16. Andreas Kienast voted on patch set 3 CR +1 05/06/20, 06:33

  17. Markus Klein voted on patch set 3 V +1 CR +1 05/06/20, 07:22

  18. Alexander Schnitzler commented on patch set 3 05/06/20, 07:35

    @Benni phpstan showed us the need for a change, not rector. I guess we could write a rector for an automatic update but since this patch is finished, I don't see it being worth it anymore.
  19. Benni Mack voted on patch set 3 V +2 CR +2 05/06/20, 11:17

  20. Benni Mack merged patch set 4 05/06/20, 11:17