Review 9.5 Merged

64418[BUGFIX] Use proper Fluid exception class

Andreas Kienast CR +2 V +2 Easy +22 −22 updated 05/06/20, 12:31

Commit message

This patch replaces the deprecated classes with their proper
replacement.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 1318

  1. Andreas Kienast uploaded patch set 1 05/06/20, 05:34

  2. TYPO3com voted on patch set 1 V -1 05/06/20, 05:34 Completed build in 21s on Wed, 6 May, 05:34 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-568

  3. Andreas Kienast uploaded patch set 2 05/06/20, 05:38

  4. Andreas Kienast uploaded patch set 3 05/06/20, 05:43

  5. Andreas Kienast uploaded patch set 4 05/06/20, 05:50

  6. TYPO3com voted on patch set 2 V -1 05/06/20, 05:51 Completed build in 12m 36s on Wed, 6 May, 05:51 AM Test Summary: 12 of 75434 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-569

  7. TYPO3com voted on patch set 3 V -1 05/06/20, 05:55 Completed build in 12m 18s on Wed, 6 May, 05:55 AM Test Summary: 12 of 75434 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-570

  8. TYPO3com voted on patch set 4 V +1 05/06/20, 06:02 Completed build in 11m 57s on Wed, 6 May, 06:02 AM Test Summary: 74834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-571

  9. Josef Glatz voted on patch set 4 CR +1 05/06/20, 06:27

  10. Markus Klein commented on patch set 4 05/06/20, 11:24

    LegacyClassesForIde.php:55

    maybe there should be both version listed here? CMS and Fluid?
  11. Josef Glatz commented on patch set 4 CR -1 05/06/20, 11:58

    LegacyClassesForIde.php:55 Reply

    I think we must change nothing in this file
  12. Josef Glatz uploaded patch set 5 05/06/20, 12:06

  13. Josef Glatz voted on patch set 5 V +1 CR +1 05/06/20, 12:07

  14. Markus Klein voted on patch set 5 V +1 CR +1 05/06/20, 12:08

  15. TYPO3com voted on patch set 5 V +1 05/06/20, 12:18 Completed build in 11m 56s on Wed, 6 May, 12:18 PM Test Summary: 74834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-576

  16. Andreas Kienast commented on patch set 5 CR -1 05/06/20, 12:29

    LegacyClassesForIde.php:55 Reply Unresolved

    That's a mistake from stupidly doing search&replace
  17. Andreas Kienast commented on patch set 5 V +2 CR +2 05/06/20, 12:30

    GERRIT!!!!
  18. Andreas Kienast merged patch set 6 05/06/20, 12:31