64418[BUGFIX] Use proper Fluid exception class
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Josef Glatz +1
- Markus Klein +1
-
Verified V +2 Done
- Andreas Kienast +2
- Josef Glatz +1
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CheckboxViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/CaseViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/DateViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/CObjectViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/ImageViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/TranslateViewHelperTest.php+1 −1
Review log 1318
-
Andreas Kienast uploaded patch set 1 05/06/20, 05:34
-
TYPO3com voted on patch set 1 V -1 05/06/20, 05:34 Completed build in 21s on Wed, 6 May, 05:34 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-568
-
Andreas Kienast uploaded patch set 2 05/06/20, 05:38
-
Andreas Kienast uploaded patch set 3 05/06/20, 05:43
-
Andreas Kienast uploaded patch set 4 05/06/20, 05:50
-
TYPO3com voted on patch set 2 V -1 05/06/20, 05:51 Completed build in 12m 36s on Wed, 6 May, 05:51 AM Test Summary: 12 of 75434 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-569
-
TYPO3com voted on patch set 3 V -1 05/06/20, 05:55 Completed build in 12m 18s on Wed, 6 May, 05:55 AM Test Summary: 12 of 75434 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-570
-
TYPO3com voted on patch set 4 V +1 05/06/20, 06:02 Completed build in 11m 57s on Wed, 6 May, 06:02 AM Test Summary: 74834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-571
-
Josef Glatz voted on patch set 4 CR +1 05/06/20, 06:27
-
Markus Klein commented on patch set 4 05/06/20, 11:24
-
Josef Glatz commented on patch set 4 CR -1 05/06/20, 11:58
LegacyClassesForIde.php:55ReplyI think we must change nothing in this file -
Josef Glatz uploaded patch set 5 05/06/20, 12:06
-
Josef Glatz voted on patch set 5 V +1 CR +1 05/06/20, 12:07
-
Markus Klein voted on patch set 5 V +1 CR +1 05/06/20, 12:08
-
TYPO3com voted on patch set 5 V +1 05/06/20, 12:18 Completed build in 11m 56s on Wed, 6 May, 12:18 PM Test Summary: 74834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-576
-
Andreas Kienast commented on patch set 5 CR -1 05/06/20, 12:29
LegacyClassesForIde.php:55Reply UnresolvedThat's a mistake from stupidly doing search&replace -
Andreas Kienast commented on patch set 5 V +2 CR +2 05/06/20, 12:30
GERRIT!!!! -
Andreas Kienast merged patch set 6 05/06/20, 12:31
LegacyClassesForIde.php:55