64419[BUGFIX] Reinitialize PageRenderer after deserialization
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Helmut Hummel +1
-
Verified V +2 Done
- Daniel Goerz +2
- Helmut Hummel +1
- TYPO3com +1 CI
Issues 3
Files 5
- typo3/sysext/core/Classes/MetaTag/MetaTagManagerRegistry.php+24 −0
- typo3/sysext/core/Classes/Page/AssetCollector.php+24 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php+37 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php7+2 −3
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −0
Review log 1520
-
Benjamin Franzke uploaded patch set 1 05/06/20, 07:08
-
TYPO3com voted on patch set 1 V +1 05/06/20, 07:18 Completed build in 10m 48s on Wed, 6 May, 07:18 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3226
-
Helmut Hummel commented on patch set 1 05/07/20, 10:03
-
Helmut Hummel commented on patch set 1 05/07/20, 10:04
TypoScriptFrontendController.php:3009ReplyMentioned in commit message already :) -
Helmut Hummel commented on patch set 1 05/07/20, 10:50
TypoScriptFrontendController.php:3003I would suggest to not serialize these objects, but only their state (either as php serialized string or json) What do you think? -
Benjamin Franzke commented on patch set 1 05/11/20, 19:35
This change is ready for review.TypoScriptFrontendController.php:3003ReplyYeah, would be better… Would that be fine for you to be delayed for v11 only? I somehow fear(ed) a breaking change when the existing (page) cache is read after a symlink change to a new TYPO3 core (classic mode) version.TypoScriptFrontendController.php:3009ReplyAh, thanks for the hint anyway, I somehow managed to overlook this call and therefore only added the TODOs to the commit message to get a first version of this patch out of my stashes. -
Benjamin Franzke voted on patch set 1 CR -1 05/11/20, 19:35
-
Benjamin Franzke uploaded patch set 2 05/11/20, 20:10
-
TYPO3com voted on patch set 2 V -1 05/11/20, 20:28 Completed build in 18m 25s on Mon, 11 May, 08:28 PM Test Summary: 4 of 74192 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3314
-
TYPO3com voted on patch set 2 V +1 05/12/20, 05:39 Completed build in 17m 00s on Tue, 12 May, 05:39 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3321
-
Helmut Hummel commented on patch set 2 06/24/20, 10:05
TypoScriptFrontendController.php:3003ReplyValid concern regarding the invalid cache entry. I'd personally say that a cache flush is required anyway after a core update (there are infact many cases where this is required), but it is also fine to do it 11 onlyTypoScriptFrontendController.php:3009ReplyDone -
Helmut Hummel updated the commit message in patch set 3 06/24/20, 10:05
-
Helmut Hummel voted on patch set 3 V +1 CR +1 06/24/20, 10:08
-
Helmut Hummel updated the commit message in patch set 4 06/24/20, 10:08
-
Helmut Hummel voted on patch set 4 V +1 CR +1 06/24/20, 10:08
-
TYPO3com voted on patch set 3 V +1 06/24/20, 10:18 Completed build in 12m 32s on Wed, 24 Jun, 10:18 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3980
-
TYPO3com voted on patch set 4 V +1 06/24/20, 10:23 Completed build in 15m 10s on Wed, 24 Jun, 10:23 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3981
-
Susi Moog commented on patch set 4 06/24/20, 10:24
This change is ready for review. -
Daniel Goerz voted on patch set 4 V +2 CR +2 06/29/20, 18:29
-
Daniel Goerz merged patch set 5 06/29/20, 18:30
TypoScriptFrontendController.php:3009