Review main Merged

64419[BUGFIX] Reinitialize PageRenderer after deserialization

Benjamin Franzke CR +2 V +2 Normal +89 −7 updated 06/29/20, 18:30

Commit message

Do not swap the global singleton instance, as
that would only update new classes that are
retrived though GeneralUtlity::makeInstance).
Existing ones (cached in already initialized
classes, or initialized via the symfony DI container
would not be updated).

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 3

Files 5

Review log 1520

  1. Benjamin Franzke uploaded patch set 1 05/06/20, 07:08

  2. TYPO3com voted on patch set 1 V +1 05/06/20, 07:18 Completed build in 10m 48s on Wed, 6 May, 07:18 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3226

  3. Helmut Hummel commented on patch set 1 05/07/20, 10:03

    TypoScriptFrontendController.php:3009

    Same needs to be done for the AssetCollector then, right?
  4. Helmut Hummel commented on patch set 1 05/07/20, 10:04

    TypoScriptFrontendController.php:3009 Reply

    Mentioned in commit message already :)
  5. Helmut Hummel commented on patch set 1 05/07/20, 10:50

    TypoScriptFrontendController.php:3003

    I would suggest to not serialize these objects, but only their state (either as php serialized string or json) What do you think?
  6. Benjamin Franzke commented on patch set 1 05/11/20, 19:35

    This change is ready for review.

    TypoScriptFrontendController.php:3003 Reply

    Yeah, would be better… Would that be fine for you to be delayed for v11 only? I somehow fear(ed) a breaking change when the existing (page) cache is read after a symlink change to a new TYPO3 core (classic mode) version.

    TypoScriptFrontendController.php:3009 Reply

    Ah, thanks for the hint anyway, I somehow managed to overlook this call and therefore only added the TODOs to the commit message to get a first version of this patch out of my stashes.
  7. Benjamin Franzke voted on patch set 1 CR -1 05/11/20, 19:35

  8. Benjamin Franzke uploaded patch set 2 05/11/20, 20:10

  9. TYPO3com voted on patch set 2 V -1 05/11/20, 20:28 Completed build in 18m 25s on Mon, 11 May, 08:28 PM Test Summary: 4 of 74192 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3314

  10. TYPO3com voted on patch set 2 V +1 05/12/20, 05:39 Completed build in 17m 00s on Tue, 12 May, 05:39 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3321

  11. Helmut Hummel commented on patch set 2 06/24/20, 10:05

    TypoScriptFrontendController.php:3003 Reply

    Valid concern regarding the invalid cache entry. I'd personally say that a cache flush is required anyway after a core update (there are infact many cases where this is required), but it is also fine to do it 11 only

    TypoScriptFrontendController.php:3009 Reply

    Done
  12. Helmut Hummel updated the commit message in patch set 3 06/24/20, 10:05

  13. Helmut Hummel voted on patch set 3 V +1 CR +1 06/24/20, 10:08

  14. Helmut Hummel updated the commit message in patch set 4 06/24/20, 10:08

  15. Helmut Hummel voted on patch set 4 V +1 CR +1 06/24/20, 10:08

  16. TYPO3com voted on patch set 3 V +1 06/24/20, 10:18 Completed build in 12m 32s on Wed, 24 Jun, 10:18 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3980

  17. TYPO3com voted on patch set 4 V +1 06/24/20, 10:23 Completed build in 15m 10s on Wed, 24 Jun, 10:23 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3981

  18. Susi Moog commented on patch set 4 06/24/20, 10:24

    This change is ready for review.
  19. Daniel Goerz voted on patch set 4 V +2 CR +2 06/29/20, 18:29

  20. Daniel Goerz merged patch set 5 06/29/20, 18:30