Review main Merged

64424[BUGFIX] Respect showHiddenFiles in filelist module

Stefan Froemken CR +2 V +2 Easy +1 −1 updated 05/22/20, 14:11

Commit message

Activating "showHiddenFilesAndFolders" in BE User
settings shows hidden files and folders also when
navigating through the files in filelist module.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Stefan Froemken uploaded patch set 1 05/06/20, 09:24

  2. TYPO3com voted on patch set 1 V +1 05/06/20, 09:36 Completed build in 12m 22s on Wed, 6 May, 09:36 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3229

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 05/06/20, 12:51

  4. Andreas Kienast commented on patch set 1 CR -1 05/06/20, 12:53

    There is no 10.4 branch, yet
  5. Andreas Kienast updated the commit message in patch set 2 05/06/20, 12:53

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 05/06/20, 12:56

  7. Daniel Goerz commented on patch set 2 05/06/20, 12:57

    Reply Unresolved

    Ah right, I actually wanted to correct that but then I did not ¯\_(ツ)_/¯
  8. TYPO3com voted on patch set 2 V +1 05/06/20, 13:04 Completed build in 11m 26s on Wed, 6 May, 01:04 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3233

  9. Josef Glatz updated the commit message in patch set 3 05/06/20, 13:06

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 05/06/20, 13:07

  11. TYPO3com voted on patch set 3 V +1 05/06/20, 13:17 Completed build in 11m 07s on Wed, 6 May, 01:17 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3234

  12. Guido Schmechel voted on patch set 3 CR +1 05/08/20, 10:43

  13. Susi Moog voted on patch set 3 V +2 CR +2 05/22/20, 14:11

  14. Susi Moog merged patch set 4 05/22/20, 14:11