Review main Abandoned

64425[TASK] Apply AddClosureReturnTypeRector

Alexander Schnitzler CR 0 V 0 Hard +225 −225 updated 05/30/21, 18:59

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 115

Show 95 more files

Review log 68

  1. Alexander Schnitzler uploaded patch set 1 05/06/20, 16:51

  2. Alexander Schnitzler rebased onto patch set 2 05/06/20, 17:00

  3. TYPO3com voted on patch set 1 V +1 05/06/20, 17:03 Completed build in 11m 36s on Wed, 6 May, 05:03 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3236

  4. Alexander Schnitzler voted on patch set 2 CR -2 05/06/20, 17:03

  5. Alexander Schnitzler wrote 05/06/20, 17:06

    Topic set to rector
  6. TYPO3com voted on patch set 2 V +1 05/06/20, 17:12 Completed build in 11m 41s on Wed, 6 May, 05:12 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3237

  7. Christian Kuhn commented on patch set 2 05/30/21, 18:58

    Hey. I hope it's ok to abandon this change for now: We dropped the rector require-dev a while ago again and in parallel a lot of stuff with phpstan is happening which gives this WIP tons of merge conflicts. Let's resurrect this patch if we go back to rector, if needed.
  8. Christian Kuhn abandoned the change 05/30/21, 18:59