64425[TASK] Apply AddClosureReturnTypeRector
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 115
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+2 −2
- typo3/sysext/adminpanel/Classes/Modules/Debug/QueryInformation.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/DebugModule.php+1 −1
- typo3/sysext/backend/Classes/Backend/ToolbarItems/UserToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+3 −3
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexProcessTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+3 −3
- typo3/sysext/beuser/Classes/Controller/BackendUserGroupController.php+1 −1
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserSessionRepository.php+3 −3
- typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php+1 −1
- typo3/sysext/core/Classes/Database/Query/BulkInsertQuery.php+2 −2
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaColumnDefinitionListener.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+3 −3
Show 95 more files
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+4 −4
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+4 −4
- typo3/sysext/core/Classes/DataHandling/Localization/State.php+2 −2
- typo3/sysext/core/Classes/DataHandling/Model/RecordStateFactory.php+1 −1
- typo3/sysext/core/Classes/DataHandling/PlaceholderShadowColumnsResolver.php+1 −1
- typo3/sysext/core/Classes/DataHandling/SlugEnricher.php+1 −1
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+1 −1
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/DefaultFunctionsProvider.php+5 −5
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/Typo3ConditionFunctionsProvider.php+2 −2
- typo3/sysext/core/Classes/Http/Uri.php+2 −2
- typo3/sysext/core/Classes/Imaging/ImageManipulation/CropVariantCollection.php+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+2 −2
- typo3/sysext/core/Classes/Resource/Search/Result/FileSearchResult.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/UserFileMountService.php+1 −1
- typo3/sysext/core/Classes/Resource/FileRepository.php+1 −1
- typo3/sysext/core/Classes/Routing/Aspect/AspectFactory.php+1 −1
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+1 −1
- typo3/sysext/core/Classes/Routing/Aspect/StaticRangeMapper.php+1 −1
- typo3/sysext/core/Classes/Routing/Enhancer/VariableProcessor.php+1 −1
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php+1 −1
- typo3/sysext/core/Classes/Routing/Route.php+2 −2
- typo3/sysext/core/Classes/Type/File/FileInfo.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.php+1 −1
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/HttpUtility.php+1 −1
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+17 −17
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/AbstractRestrictionTestCase.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Query/QueryHelperTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Types/EnumTypeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Types/SetTypeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/FailsafeContainerTest.php+16 −16
- typo3/sysext/core/Tests/Unit/ExpressionLanguage/ResolverTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+2 −2
- typo3/sysext/dashboard/Classes/Widgets/RssWidget.php+1 −1
- typo3/sysext/dashboard/Classes/WidgetRegistry.php+1 −1
- typo3/sysext/dashboard/Tests/Unit/DependencyInjection/DashboardWidgetPassTest.php+6 −6
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Method.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+5 −5
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php+4 −4
- typo3/sysext/extbase/Classes/Service/CacheService.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Property/PropertyMapperTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ExtensionModelUtilityTest.php+2 −2
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/fluid/Tests/Unit/View/TemplatePathsTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/ButtonViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/BytesViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/CropViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/DateViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/HtmlentitiesDecodeViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/HtmlentitiesViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/Nl2brViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/NumberViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/PaddingViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/ExternalViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/PageViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/CObjectViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FlashMessagesViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/TranslateViewHelperTest.php+3 −3
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+1 −1
- typo3/sysext/form/Classes/Hooks/FormFileExtensionUpdate.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/ClosureFinisherTest.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/StaticRouteResolver.php+1 −1
- typo3/sysext/frontend/Classes/Resource/FileCollector.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/ApplicableConjunction.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Permutation.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/TestSet.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+4 −4
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGeneratorTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequestTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+3 −3
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcher.php+1 −1
- typo3/sysext/install/Classes/Service/EnableFileService.php+1 −1
- typo3/sysext/install/Classes/Service/LanguagePackService.php+2 −2
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceVersionRecordMigrationTest.php+1 −1
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+6 −6
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/redirects/Classes/Controller/RecordHistoryRollbackController.php+1 −1
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+1 −1
- typo3/sysext/workspaces/Classes/Service/StagesService.php+1 −1
Review log 68
-
Alexander Schnitzler uploaded patch set 1 05/06/20, 16:51
-
Alexander Schnitzler rebased onto patch set 2 05/06/20, 17:00
-
TYPO3com voted on patch set 1 V +1 05/06/20, 17:03 Completed build in 11m 36s on Wed, 6 May, 05:03 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3236
-
Alexander Schnitzler voted on patch set 2 CR -2 05/06/20, 17:03
-
Alexander Schnitzler wrote 05/06/20, 17:06
Topic set to rector -
TYPO3com voted on patch set 2 V +1 05/06/20, 17:12 Completed build in 11m 41s on Wed, 6 May, 05:12 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3237
-
Christian Kuhn commented on patch set 2 05/30/21, 18:58
Hey. I hope it's ok to abandon this change for now: We dropped the rector require-dev a while ago again and in parallel a lot of stuff with phpstan is happening which gives this WIP tons of merge conflicts. Let's resurrect this patch if we go back to rector, if needed. -
Christian Kuhn abandoned the change 05/30/21, 18:59