Review main Abandoned

64426[TASK] Apply ReturnTypeDeclarationRector

Alexander Schnitzler CR 0 V 0 Impossible +13990 −14009 updated 05/30/21, 18:59

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 2149

Show 2129 more files

Review log 910

  1. Alexander Schnitzler uploaded patch set 1 05/06/20, 17:27

  2. Alexander Schnitzler wrote 05/06/20, 17:27

    Topic set to rector
  3. Alexander Schnitzler voted on patch set 1 CR -2 05/06/20, 17:30

  4. TYPO3com voted on patch set 1 V -1 05/06/20, 17:37 Completed build in 10m 03s on Wed, 6 May, 05:37 PM Test Summary: 3 of 1096 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3238

  5. Stephan Großberndt commented on patch set 1 05/07/20, 08:27

    This change is ready for review.

    BackendUserAuthentication.php:2295

    This is wrong. The phpdoc return type is declared as int, where does void stem from? PHP Fatal error: A void function must not return a value in /srv/bamboo/xml-data/build-dir/CORE-GTC-ACPTMY0PHP73/typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php on line 2347
  6. Alexander Schnitzler commented on patch set 1 05/07/20, 09:30

    BackendUserAuthentication.php:2295 Reply Unresolved

    Well, rector is not without failure. I can't tell you why rector made a mistake here but it shows, that if we use rector, we need to apply changes in smaller chunks and review very properly. btw: I hope you don't review this patch fully, it's just a demo and not meant to be merged.
  7. Alexander Schnitzler marked it work in progress 05/07/20, 09:31

  8. Alexander Schnitzler commented on patch set 1 05/07/20, 09:31

    I seem to have pushed this patch not as WIP. I am sorry for that.
  9. Christian Kuhn commented on patch set 1 05/30/21, 18:59

    Hey. I hope it's ok to abandon this change for now: We dropped the rector require-dev a while ago again and in parallel a lot of stuff with phpstan is happening which gives this WIP tons of merge conflicts. Let's resurrect this patch if we go back to rector, if needed.
  10. Christian Kuhn abandoned the change 05/30/21, 18:59