Review main Merged

64428[BUGFIX] Correctly evaluate "unique" eval for slug fields

K�nig David CR +2 V +2 Normal +144 −0 updated 05/13/20, 09:41

Commit message

TYPO3 v9.5.16, fixed functionality for URL resolving
for records with slug fields defined as "uniqueInSite".
With such setting, it is important to limit URL resolving
to the site the slugs are generated for. Because we currently
don't support records to be stored within one site, but
generating slugs for another one, this change enforced the storage
of news records to be in the same site as the detail page.

This however led to not working installations, where a record storage
folder is available in a site where other sites are fetching this
information from, which is a quite common use case.

To cover such use case, TCA needs to be adapted to the existing configuration
eval=unique, which diables the site check in URL frontend resolving.
However the current implementation of DataHandler only checks uniqueness
of fields of type "input".

This means for slug fields, the functionality of 'unique'
is currently not taken into account when generating the slug,
which can lead to duplicate slugs.
To fix this problem, a check for the unique eval setting is added to
DataHandler and FormSlugAjaxController. SlugHelper is adapted
to correctly generate slugs for this use case.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Henrik Ziegenhain +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1726

Show 1 earlier messages
  1. K�nig David uploaded patch set 1 05/07/20, 00:27

  1. TYPO3com voted on patch set 1 V -1 05/07/20, 00:27 Completed build in 29s on Thu, 7 May, 12:27 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3240

  2. Josef Glatz commented on patch set 1 CR -1 05/07/20, 07:34

    Regardless of the technical part of the patch, a meaningful description of what the patch is doing / changing is missing.
  3. Josef Glatz wrote 05/07/20, 07:34

    Removed reviewer Josef Glatz with the following votes: * Code-Review-1 by Josef Glatz <josefglatz@gmail.com>
  4. K�nig David uploaded patch set 2 05/07/20, 09:53

  5. TYPO3com voted on patch set 2 V -1 05/07/20, 09:53 Completed build in 29s on Thu, 7 May, 09:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3241

  6. Helmut Hummel uploaded patch set 3 05/08/20, 11:25

  7. TYPO3com voted on patch set 3 V -1 05/08/20, 11:36 Completed build in 11m 24s on Fri, 8 May, 11:36 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3258

  8. Helmut Hummel uploaded patch set 4 05/08/20, 11:37

  9. TYPO3com voted on patch set 4 V +1 05/08/20, 11:49 Completed build in 11m 31s on Fri, 8 May, 11:49 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3259

  10. Helmut Hummel uploaded patch set 5 05/08/20, 12:36

  11. TYPO3com voted on patch set 5 V -1 05/08/20, 12:39 Completed build in 01m 08s on Fri, 8 May, 12:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3261

  12. Helmut Hummel updated the commit message in patch set 6 05/08/20, 14:04

  13. TYPO3com voted on patch set 6 V -1 05/08/20, 14:04 Completed build in 27s on Fri, 8 May, 02:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3262

  14. Helmut Hummel uploaded patch set 7 05/08/20, 14:05

  15. Helmut Hummel updated the commit message in patch set 8 05/08/20, 14:05

  16. Helmut Hummel commented on patch set 8 05/08/20, 14:06

    Reply

    Done
  17. TYPO3com voted on patch set 7 V -1 05/08/20, 14:17 Completed build in 12m 04s on Fri, 8 May, 02:17 PM Test Summary: 1 of 74189 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3263

  18. TYPO3com voted on patch set 8 V +1 05/08/20, 14:22 Completed build in 16m 14s on Fri, 8 May, 02:22 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3264

  19. Helmut Hummel updated the commit message in patch set 9 05/08/20, 17:37

  20. TYPO3com voted on patch set 9 V +1 05/08/20, 17:50 Completed build in 12m 37s on Fri, 8 May, 05:50 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3272

  21. Benni Mack voted on patch set 9 V +1 CR +1 05/09/20, 09:13

  22. Henrik Ziegenhain voted on patch set 9 CR +1 05/09/20, 12:10

  23. Helmut Hummel voted on patch set 9 V +2 CR +2 05/11/20, 15:18

  24. Helmut Hummel merged patch set 10 05/11/20, 15:18

  25. Xavier Perseguers commented on patch set 10 05/13/20, 09:41

    A quick search seems to point here. I have the feeling that something went wrong with this fix: https://github.com/georgringer/news/issues/1274