64428[BUGFIX] Correctly evaluate "unique" eval for slug fields
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Henrik Ziegenhain +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php+5 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −0
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+52 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/TestSlugUniqueBase.csvnew+5 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/TestSlugUniqueResult.csvnew+5 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SlugUniqueTest.phpnew+74 −0
Review log 1726
Show 1 earlier messages
-
K�nig David uploaded patch set 1 05/07/20, 00:27
-
TYPO3com voted on patch set 1 V -1 05/07/20, 00:27 Completed build in 29s on Thu, 7 May, 12:27 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3240
-
Josef Glatz commented on patch set 1 CR -1 05/07/20, 07:34
Regardless of the technical part of the patch, a meaningful description of what the patch is doing / changing is missing. -
Josef Glatz wrote 05/07/20, 07:34
Removed reviewer Josef Glatz with the following votes: * Code-Review-1 by Josef Glatz <josefglatz@gmail.com> -
K�nig David uploaded patch set 2 05/07/20, 09:53
-
TYPO3com voted on patch set 2 V -1 05/07/20, 09:53 Completed build in 29s on Thu, 7 May, 09:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3241
-
Helmut Hummel uploaded patch set 3 05/08/20, 11:25
-
TYPO3com voted on patch set 3 V -1 05/08/20, 11:36 Completed build in 11m 24s on Fri, 8 May, 11:36 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3258
-
Helmut Hummel uploaded patch set 4 05/08/20, 11:37
-
TYPO3com voted on patch set 4 V +1 05/08/20, 11:49 Completed build in 11m 31s on Fri, 8 May, 11:49 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3259
-
Helmut Hummel uploaded patch set 5 05/08/20, 12:36
-
TYPO3com voted on patch set 5 V -1 05/08/20, 12:39 Completed build in 01m 08s on Fri, 8 May, 12:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3261
-
Helmut Hummel updated the commit message in patch set 6 05/08/20, 14:04
-
TYPO3com voted on patch set 6 V -1 05/08/20, 14:04 Completed build in 27s on Fri, 8 May, 02:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3262
-
Helmut Hummel uploaded patch set 7 05/08/20, 14:05
-
Helmut Hummel updated the commit message in patch set 8 05/08/20, 14:05
-
Helmut Hummel commented on patch set 8 05/08/20, 14:06
Reply
Done -
TYPO3com voted on patch set 7 V -1 05/08/20, 14:17 Completed build in 12m 04s on Fri, 8 May, 02:17 PM Test Summary: 1 of 74189 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3263
-
TYPO3com voted on patch set 8 V +1 05/08/20, 14:22 Completed build in 16m 14s on Fri, 8 May, 02:22 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3264
-
Helmut Hummel updated the commit message in patch set 9 05/08/20, 17:37
-
TYPO3com voted on patch set 9 V +1 05/08/20, 17:50 Completed build in 12m 37s on Fri, 8 May, 05:50 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3272
-
Benni Mack voted on patch set 9 V +1 CR +1 05/09/20, 09:13
-
Henrik Ziegenhain voted on patch set 9 CR +1 05/09/20, 12:10
-
Helmut Hummel voted on patch set 9 V +2 CR +2 05/11/20, 15:18
-
Helmut Hummel merged patch set 10 05/11/20, 15:18
-
Xavier Perseguers commented on patch set 10 05/13/20, 09:41
A quick search seems to point here. I have the feeling that something went wrong with this fix: https://github.com/georgringer/news/issues/1274