Review main Merged

64429[TASK] Apply ParamTypeDeclarationRector on private methods

Alexander Schnitzler CR +2 V +2 Easy +7 −7 updated 10/08/21, 16:17

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1419

  1. Alexander Schnitzler uploaded patch set 1 05/07/20, 10:32

  2. TYPO3com voted on patch set 1 V +1 05/07/20, 10:43 Completed build in 11m 04s on Thu, 7 May, 10:43 AM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3242

  3. Alexander Schnitzler uploaded patch set 2 10/06/20, 12:48

  4. TYPO3com voted on patch set 2 V -1 10/06/20, 13:09 Completed build in 18m 39s on Tue, 6 Oct, 01:09 PM Test Summary: 2 of 74270 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6275

  5. TYPO3com voted on patch set 2 V +1 10/06/20, 13:14 Completed build in 42m 03s on Tue, 6 Oct, 01:14 PM Test Summary: 73783 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6275

  6. Benni Mack uploaded patch set 3 09/17/21, 08:18

  7. Benni Mack marked it ready for review 09/17/21, 08:18

  8. core-ci voted on patch set 3 V +1 09/17/21, 08:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16857

  9. Wouter Wolters voted on patch set 3 CR +1 09/17/21, 08:36

  10. Georg Ringer voted on patch set 3 CR +1 09/17/21, 08:46

  11. Benni Mack voted on patch set 3 V +1 CR +1 09/17/21, 08:56

  12. Alexander Schnitzler commented on patch set 3 09/17/21, 09:21

    I guess you re-ran rector, right?
  13. Benni Mack commented on patch set 3 09/17/21, 09:30

    Reply

    I did manual checks on all "private function"s Should we add the rector?
  14. Benni Mack uploaded patch set 4 10/08/21, 12:50

  15. Benni Mack commented on patch set 4 V +1 CR +1 10/08/21, 12:50

    Reply

    Ack
  16. core-ci voted on patch set 4 V +1 10/08/21, 13:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17815

  17. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/08/21, 13:55

  18. Benni Mack voted on patch set 4 V +2 CR +2 10/08/21, 16:17

  19. Benni Mack merged patch set 5 10/08/21, 16:17