Review main Abandoned

64430[TASK] Apply ParamTypeDeclarationRector on protected methods

Alexander Schnitzler CR 0 V 0 Expert +958 −976 updated 06/09/21, 20:44

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 302

Show 282 more files

Review log 58

  1. Alexander Schnitzler uploaded patch set 1 05/07/20, 11:09

  2. TYPO3com voted on patch set 1 V -1 05/07/20, 11:17 Completed build in 07m 18s on Thu, 7 May, 11:17 AM Test Summary: 7576 of 25423 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3243

  3. Alexander Schnitzler uploaded patch set 2 10/06/20, 12:44

  4. TYPO3com voted on patch set 2 V -1 10/06/20, 12:44 Completed build in 21s on Tue, 6 Oct, 12:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6273

  5. Alexander Schnitzler uploaded patch set 3 10/06/20, 12:53

  6. TYPO3com voted on patch set 3 V -1 10/06/20, 13:14 Completed build in 16m 53s on Tue, 6 Oct, 01:14 PM Test Summary: 9067 of 32507 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6276

  7. Christian Kuhn commented on patch set 3 CR -1 06/09/21, 20:44

    Hey. I hope it's ok to abandon this change for now: We dropped the rector require-dev a while ago again and in parallel a lot of stuff with phpstan is happening which gives this WIP tons of merge conflicts. Let's resurrect this patch if we go back to rector, if needed.
  8. Christian Kuhn abandoned the change 06/09/21, 20:44