Review main Merged

64431[BUGFIX] Revert PageReadPermission check for TreeController

Benni Mack CR +2 V +2 Easy +38 −7 updated 05/12/20, 07:17

Commit message

In order to allow non-admins to fetch nodes which have no "pid=0"
the change to only fetch pages with access, the change to
check on a DB query basis is reverted.

Additionally a functional tests is extended to cover the problematic case.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Tymoteusz Motylewski +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1216

  1. Benni Mack uploaded patch set 1 05/07/20, 12:36

  2. TYPO3com voted on patch set 1 V +1 05/07/20, 12:47 Completed build in 11m 34s on Thu, 7 May, 12:47 PM Test Summary: 73688 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3244

  3. Benni Mack updated the commit message in patch set 2 05/08/20, 17:02

  4. TYPO3com voted on patch set 2 V +1 05/08/20, 17:19 Completed build in 16m 47s on Fri, 8 May, 05:19 PM Test Summary: 73696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3270

  5. Patrick Schriner voted on patch set 2 V +1 CR +1 05/11/20, 12:53

  6. Tymoteusz Motylewski commented on patch set 2 CR -2 05/11/20, 20:01

    on it
  7. Oliver Hader voted on patch set 2 CR +1 05/11/20, 20:03

  8. Tymoteusz Motylewski uploaded patch set 3 05/11/20, 20:11

  9. Tymoteusz Motylewski commented on patch set 3 CR 0 05/11/20, 20:11

    ready for review, now with additional test
  10. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 05/11/20, 20:14

  11. Benni Mack voted on patch set 3 V +1 CR +1 05/11/20, 20:16

  12. Oliver Hader voted on patch set 3 CR +1 05/11/20, 20:27

  13. TYPO3com voted on patch set 3 V -1 05/11/20, 20:36 Completed build in 18m 33s on Mon, 11 May, 08:36 PM Test Summary: 2 of 74190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3315

  14. TYPO3com voted on patch set 3 V +1 05/12/20, 06:13 Completed build in 10h 14m 22s on Tue, 12 May, 06:13 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3315

  15. Benni Mack voted on patch set 3 V +2 CR +2 05/12/20, 07:17

  16. Benni Mack merged patch set 4 05/12/20, 07:17