Review main Merged

64435[DOCS] ext:dashboard presets feature

Daniel Siepmann CR +2 V +2 Normal +98 −1 updated 05/12/20, 06:48

Commit message

The system extension ext:dashboard provides a way to register presets of
dashboards.
These presets can be configured via User TSconfig, if the user doesn't
have a dashboard yet.

Review

  • Code review CR +2 Done
    • Daniel Siepmann +2
    • Josef Glatz +1
    • Richard Haeser +1
    • Koen Wouters +1
  • Verified V +2 Done
    • Daniel Siepmann +2
    • Josef Glatz +1
    • Richard Haeser +1
    • Koen Wouters +1

Issues 1

Files 3

Review log 1419

  1. Daniel Siepmann uploaded patch set 1 05/07/20, 16:04

  2. Daniel Goerz commented on patch set 2 05/07/20, 16:25

    Published edit on patch set 1.
  3. TYPO3com voted on patch set 1 V -1 05/07/20, 16:30 Completed build in 26m 03s on Thu, 7 May, 04:30 PM Test Summary: 1 of 72232 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3249

  4. TYPO3com voted on patch set 2 V -1 05/07/20, 16:39 Completed build in 14m 15s on Thu, 7 May, 04:39 PM Test Summary: 1 of 74174 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3250

  5. TYPO3com voted on patch set 2 V +1 05/07/20, 16:47 Completed build in 36m 27s on Thu, 7 May, 04:47 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3250

  6. Richard Haeser commented on patch set 2 05/07/20, 17:47

    Maybe add an example based on groups? So how to add presets per group? If needed, I can check and add a new patchset tomorrow
  7. Daniel Siepmann uploaded patch set 3 05/07/20, 19:17

  8. TYPO3com voted on patch set 3 V +1 05/07/20, 19:29 Completed build in 11m 20s on Thu, 7 May, 07:28 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3252

  9. Richard Haeser voted on patch set 3 V +1 CR +1 05/12/20, 06:02

  10. Josef Glatz voted on patch set 3 V +1 CR +1 05/12/20, 06:05

  11. Daniel Siepmann marked it work in progress 05/12/20, 06:22

  12. Daniel Siepmann uploaded patch set 4 05/12/20, 06:32

  13. Daniel Siepmann commented on patch set 4 05/12/20, 06:32

    This change is ready for review.
  14. Richard Haeser voted on patch set 4 V +1 CR +1 05/12/20, 06:35

  15. Koen Wouters voted on patch set 4 V +1 CR +1 05/12/20, 06:40

  16. Daniel Siepmann voted on patch set 4 V +2 CR +2 05/12/20, 06:41

  17. Daniel Siepmann merged patch set 5 05/12/20, 06:41

  18. Josef Glatz voted on patch set 5 V +1 CR +1 05/12/20, 06:41

  19. TYPO3com voted on patch set 4 V +1 05/12/20, 06:48 Completed build in 15m 59s on Tue, 12 May, 06:48 AM Test Summary: 73703 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3322