Review main Merged

64436[BUGFIX] Fix HMENU special=directory when site language is in free mode

Benni Mack CR +2 V +2 Easy +16 −0 updated 05/11/20, 07:14

Commit message

When setting a site language into free mode for translations, then
"$cObj->exec_getQuery()" only returns the pages without overlays.
HMENU however always expects sys_language_uid=0 records, as it does a
MountPoint + overlay again. Doing an getPageOverlay of a translated page
results in an empty result.

The change now modifies the HMENU directory resolving
to fetch the original record (cached in PageRepository), and do
the overlay information as well.

This also fixes the same issue in HMENU.special = updated

Big Kudos to Jones for great support on tackling this issue!

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jonas Temmen +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Temmen +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Benni Mack uploaded patch set 1 05/07/20, 20:08

  2. Benni Mack updated the commit message in patch set 2 05/07/20, 20:08

  3. TYPO3com voted on patch set 1 V +1 05/07/20, 20:20 Completed build in 12m 08s on Thu, 7 May, 08:20 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3254

  4. TYPO3com voted on patch set 2 V -1 05/07/20, 20:25 Completed build in 15m 46s on Thu, 7 May, 08:25 PM Test Summary: 1 of 74174 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3255

  5. TYPO3com voted on patch set 2 V +1 05/07/20, 20:27 Completed build in 33m 37s on Thu, 7 May, 08:27 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3255

  6. Wouter Wolters voted on patch set 2 CR +1 05/07/20, 21:07

  7. Jonas Temmen commented on patch set 2 V +1 CR +1 05/08/20, 07:30

    Tested in all 3 modes with 2 languages. Works for me!
  8. Benni Mack voted on patch set 2 V +2 CR +2 05/11/20, 07:14

  9. Benni Mack merged patch set 3 05/11/20, 07:14