Review main Merged

64439[BUGFIX] Do not deprecate $GLOBALS[TYPO3_REQUEST]

Benni Mack CR +2 V +2 Easy +2 −44 updated 05/11/20, 06:38

Commit message

The global object $GLOBALS[TYPO3_REQUEST] holding the
current PSR-7 request object was introduced in TYPO3 v9.2.

However, it was also marked as deprecated as we thought we
were able to remove all usages again by the end of TYPO3 v9.5
development, which shows that we have more problems in various
areas like hooks and Extbase where we heavily rely on this object.

For this reason, it is kept but the original Feature RST still contains
the information that it is considered bad practice.

Removing the deprecation will result in better result for the
ExtensionScanner.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 35

  1. Benni Mack uploaded patch set 1 05/08/20, 17:00

  2. TYPO3com voted on patch set 1 V -1 05/08/20, 17:13 Completed build in 12m 48s on Fri, 8 May, 05:13 PM Test Summary: 2 of 74180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3269

  3. TYPO3com voted on patch set 1 V +1 05/09/20, 09:22 Completed build in 16h 34m 04s on Sat, 9 May, 09:22 AM Test Summary: 73696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3269

  4. Benni Mack voted on patch set 1 V +2 CR +2 05/11/20, 06:38

  5. Benni Mack merged patch set 2 05/11/20, 06:38