Review main Merged

64444[BUGFIX] Set changed state of FormEngine when null placeholder fields are changed

Andreas Kienast CR +2 V +2 Normal +87 −0 updated 05/15/20, 06:27

Commit message

When a null placeholder checkbox is changed, the linked form field is
now marked as "changed", which triggers the confirmation when leaving
the form while being unsaved.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Josef Glatz +1
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Susi Moog +2
    • Josef Glatz +1
    • Xavier Perseguers +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Andreas Kienast uploaded patch set 1 05/10/20, 13:39

  2. Andreas Kienast uploaded patch set 2 05/10/20, 13:41

  3. TYPO3com voted on patch set 1 V +1 05/10/20, 13:51 Completed build in 11m 58s on Sun, 10 May, 01:51 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3285

  4. TYPO3com voted on patch set 2 V -1 05/10/20, 13:56 Completed build in 15m 02s on Sun, 10 May, 01:56 PM Test Summary: 1 of 74181 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3286

  5. TYPO3com voted on patch set 2 V +1 05/10/20, 14:00 Completed build in 34m 03s on Sun, 10 May, 02:00 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3286

  6. Josef Glatz voted on patch set 2 V +1 CR +1 05/14/20, 07:28

  7. Xavier Perseguers commented on patch set 2 V +1 CR +1 05/14/20, 08:52

    Many thanks
  8. Susi Moog voted on patch set 2 V +2 CR +2 05/15/20, 06:27

  9. Susi Moog merged patch set 3 05/15/20, 06:27