Review main Merged Breaking

64446[!!!][TASK] Remove deprecated md5.js

Andreas Kienast CR +2 V +2 Normal +1 −228 updated 05/29/20, 07:30

Commit message

The library md5.js has been removed in favor of the
TYPO3/CMS/Backend/Hashing/Md5 module.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Daniel Haupt +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 712

  1. Andreas Kienast uploaded patch set 1 05/10/20, 14:07

  2. TYPO3com voted on patch set 1 V -1 05/10/20, 14:20 Completed build in 12m 02s on Sun, 10 May, 02:20 PM Test Summary: 1 of 74180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3288

  3. TYPO3com voted on patch set 1 V +1 05/10/20, 14:24 Completed build in 28m 30s on Sun, 10 May, 02:24 PM Test Summary: 73696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3288

  4. Andreas Kienast uploaded patch set 2 05/27/20, 06:07

  5. TYPO3com voted on patch set 2 V -1 05/27/20, 06:07 Completed build in 19s on Wed, 27 May, 06:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3589

  6. Andreas Kienast rebased onto patch set 3 05/28/20, 07:47

  7. TYPO3com voted on patch set 3 V -1 05/28/20, 08:10 Completed build in 22m 46s on Thu, 28 May, 08:10 AM Test Summary: 2 of 74198 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3603

  8. TYPO3com voted on patch set 3 V +1 05/28/20, 09:31 Completed build in 2h 06m 37s on Thu, 28 May, 09:31 AM Test Summary: 73709 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3603

  9. Benni Mack voted on patch set 3 V +1 CR +1 05/28/20, 14:52

  10. Daniel Haupt voted on patch set 3 CR +1 05/28/20, 20:50

  11. Benjamin Franzke voted on patch set 3 V +2 CR +2 05/29/20, 07:30

  12. Benjamin Franzke merged patch set 4 05/29/20, 07:30