Review main Merged

64453[BUGFIX] Only call getMovePlaceholder for MOVE_POINTER records

Benni Mack CR +2 V +2 Easy +3 −1 updated 05/11/20, 19:26

Commit message

Since isInWebMount now calls BEgetRootline with workspace overlays,
an additional query for ALL requested pages in rootline is made, because
getMovePlaceholder() is called every time and does not know the
actual record - getMovePlaceholder should only be called on MOVE_POINTER
records.

An additional check makes the Page tree work again for editors in workspaces.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 05/11/20, 12:50

  2. Benni Mack updated the commit message in patch set 2 05/11/20, 12:50

  3. Achim Fritz voted on patch set 2 V +1 CR +1 05/11/20, 12:56

  4. Oliver Hader commented on patch set 2 CR +1 05/11/20, 12:57

    BackendUtility.php:478 Unresolved

    4th parameter could be `$row['t3ver_wsid']`... however since workspaceOL is not using it, it's probably fine to omit it
  5. TYPO3com voted on patch set 1 V +1 05/11/20, 13:01 Completed build in 11m 31s on Mon, 11 May, 01:01 PM Test Summary: 73696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3303

  6. TYPO3com voted on patch set 2 V +1 05/11/20, 13:07 Completed build in 16m 44s on Mon, 11 May, 01:07 PM Test Summary: 73696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3304

  7. Benni Mack voted on patch set 2 V +2 CR +2 05/11/20, 19:26

  8. Benni Mack merged patch set 3 05/11/20, 19:26